Manual:$wgResourceModuleSkinStyles docs link to Vector as an example but that uses ResourceModuleSkinStyles
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Aklapper
	Apr 4 2021, 8:34 AM

Description

Current revision of https://www.mediawiki.org/wiki/Manual:$wgResourceModuleSkinStyles states

[[Skin:Vector|Vector]] is one of the skins using this method, and provides a good '''practical usage demonstration''': https://phabricator.wikimedia.org/diffusion/SVEC/browse/master/skin.json;master$70

However there is no use of wgResourceModuleSkinStyles in current git master in that file.

That line on the wiki page was originally added in 2014 in https://www.mediawiki.org/w/index.php?title=Manual:$wgResourceModuleSkinStyles&type=revision&diff=1083141&oldid=1083135 and linked at that time to Vector.php at https://phabricator.wikimedia.org/source/mediawiki/browse/master/skins/Vector/Vector.php;1ebad72b0b45209ab04562716af0d1ff7b4efda6$66 (which probably got moved to skin.json later).

Should that line just be removed? Or is there a better place to point to?

(Plus hardcoding a line number against everchanging git master is not a good idea.)

Event Timeline

Aklapper created this task.Apr 4 2021, 8:34 AM

Restricted Application added a project: Performance-Team. · View Herald TranscriptApr 4 2021, 8:34 AM

In skin.json, this is represented by ResourceModuleSkinStyles. The wg prefix is omitted. https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#ResourceModuleSkinStyles mentions that the ResourceModuleSkinStyles represents $wgResourceModuleSkinStyles, but not all documentation pages have been updated to include information on how to use them with extension registration.

Perhaps we can extend Template:SettingSummary with a field to indicate what the corresponding name is in extension.json/skin.json.

@Mainframe98: Thanks for https://www.mediawiki.org/w/index.php?title=Manual:$wgResourceModuleSkinStyles&type=revision&diff=4510219&oldid=4388076 (plus for understanding this way better than I do). I guess my skills to scroll down were suboptimal this morning. :)

Aklapper renamed this task from Manual:$wgResourceModuleSkinStyles docs link to Vector as an example but Vector does not use it to Manual:$wgResourceModuleSkinStyles docs link to Vector as an example but that uses ResourceModuleSkinStyles.Apr 4 2021, 11:05 AM

• Gilles moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Apr 5 2021, 7:10 PM

Krinkle moved this task from Inbox to Accepted Enhancement on the MediaWiki-ResourceLoader board.Apr 5 2021, 7:10 PM

Krinkle closed this task as Resolved.Sep 26 2021, 9:56 PM

Krinkle claimed this task.

Manual:$wgResourceModuleSkinStyles docs link to Vector as an example but that uses ResourceModuleSkinStylesClosed, ResolvedPublicActions

Description

Event Timeline

Manual:$wgResourceModuleSkinStyles docs link to Vector as an example but that uses ResourceModuleSkinStyles
Closed, ResolvedPublic
Actions