Page MenuHomePhabricator

WANObjectCache calls to setNewPreparedValues() cannot have serialized values reused
Closed, ResolvedPublic

Description

Since the call in checkAndSetCooloff() passes $value (what the cache caller gave) and not the $wrapped value (what WANObjectCache::set/setInterimValue actually use), any serialization will be wasted.

This doesn't matter for MemcachedPeclBagOStuff, since setNewPreparedValues() just uses guessSerialValueSize().