Page MenuHomePhabricator
Create Task
Maniphest T280193

ContentHandler::getChangeType is limited to a single type per edit, ignoring content model changes
Open, Needs TriagePublicBUG REPORT
Actions

Description

getChangeType is used for both automatic summaries and automatic change tags. While having just a single type is great for the automatic summary logic, it isn't good for the logic to automatically add change tags, since multiple tags can be valid. Specifically, while most of the tags shouldn't be combined, since they are either mutually exclusive or one implies the other (blanking the page includes removing a redirect, creating a new page that is a redirect includes creating a new page) content model change can be combined with the others

Details

SubjectRepoBranchLines +/-
Delete lint errors when blank page saved while changing content typemediawiki/extensions/Lintermaster+4 -6
ContentHandler: add multiple automatic tags to edits if neededmediawiki/coremaster+86 -54
Customize query in gerrit

Event Timeline

DannyS712 created this task.Apr 14 2021, 9:24 PM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptApr 14 2021, 9:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 changed the subtype of this task from "Task" to "Bug Report".Apr 14 2021, 9:24 PM
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Apr 14 2021, 9:26 PM

Change 679448 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] ContentHandler: add multiple automatic tags to edits if needed

https://gerrit.wikimedia.org/r/679448

gerritbot added a project: Patch-For-Review.Apr 14 2021, 9:26 PM
DannyS712 renamed this task from ContentHandler::getChangeType is limited to a single type per edit to ContentHandler::getChangeType is limited to a single type per edit, ignoring content model changes.Apr 14 2021, 9:33 PM
DannyS712 updated the task description. (Show Details)
DannyS712 updated the task description. (Show Details)Apr 14 2021, 9:55 PM
ssastry subscribed.Feb 25 2022, 10:13 PM

When this is fixed, a test in Linter extension will need an update. See https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/761070/13/tests/phpunit/SpecialLintErrorsTest.php#157

gerritbot added a comment.Feb 28 2022, 10:50 PM

Change 766872 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/extensions/Linter@master] Delete lint errors when blank page saved while changing content type

https://gerrit.wikimedia.org/r/766872

Sbailey claimed this task.Feb 28 2022, 10:53 PM
Sbailey subscribed.

Lint errors are now being deleted during save of a blank page while the content model is being changed.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Linter/+/766872

gerritbot added a comment.Feb 28 2022, 11:24 PM

Change 766872 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Delete lint errors when blank page saved while changing content type

https://gerrit.wikimedia.org/r/766872

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.24; 2022-02-28).Mar 1 2022, 12:00 AM
Sbailey removed Sbailey as the assignee of this task.Mar 1 2022, 3:32 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Jun 4 2023, 5:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL