Page MenuHomePhabricator

Update mwbot to v2
Closed, ResolvedPublic

Description

I'm doing something wrong, because [MWBOT] Login successful message is still there after the upgrade to mwbot v2. 🤷‍♂️

1~/Documents/gerrit/mediawiki/core$ npm run selenium-test
2
3> @ selenium-test /Users/z/Documents/gerrit/mediawiki/core
4> wdio ./tests/selenium/wdio.conf.js
5
6
7Execution of 6 spec files started at 2021-04-16T13:49:25.443Z
8
9[0-0] RUNNING in chrome - /tests/selenium/wdio-mediawiki/specs/BlankPage.js
10[0-0]
11 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/BlankPage-should-have-its-title-%40daily.png
12
13[0-0] PASSED in chrome - /tests/selenium/wdio-mediawiki/specs/BlankPage.js
14[0-1] RUNNING in chrome - /tests/selenium/specs/page.js
15[0-1] [15:49:30] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
16[0-1]
17 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-previewable.png
18
19[0-1]
20 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-creatable.png
21
22[0-1]
23 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-re-creatable.png
24
25[0-1]
26 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-editable-%40daily.png
27
28[0-1]
29 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-have-history-%40daily.png
30
31[0-1]
32 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-deletable.png
33
34[0-1]
35 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-restorable.png
36
37[0-1] PASSED in chrome - /tests/selenium/specs/page.js
38[0-2] RUNNING in chrome - /tests/selenium/specs/rollback.js
39[0-2] PASSED in chrome - /tests/selenium/specs/rollback.js
40[0-3] RUNNING in chrome - /tests/selenium/specs/specialrecentchanges.js
41[0-3] [15:50:05] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
42[0-3]
43 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Special%3ARecentChanges-shows-page-creation.png
44
45[0-3] PASSED in chrome - /tests/selenium/specs/specialrecentchanges.js
46[0-4] RUNNING in chrome - /tests/selenium/specs/specialwatchlist.js
47[0-4] [15:50:12] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
48[0-4]
49 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Special%3AWatchlist-should-show-page-with-new-edit.png
50
51[0-4] PASSED in chrome - /tests/selenium/specs/specialwatchlist.js
52[0-5] RUNNING in chrome - /tests/selenium/specs/user.js
53[0-5] [15:50:24] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
54[0-5]
55 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/User-should-be-able-to-create-account.png
56
57[0-5]
58 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/User-should-be-able-to-log-in-%40daily.png
59
60[0-5] PASSED in chrome - /tests/selenium/specs/user.js
61
62 "dot" Reporter:
63....................
64
65Spec Files: 6 passed, 6 total (100% completed) in 00:01:06

1~/Documents/gerrit/mediawiki/core$ git diff
2diff --git a/package-lock.json b/package-lock.json
3index 392f501c87..f2f87a3a8d 100644
4--- a/package-lock.json
5+++ b/package-lock.json
6@@ -11859,7 +11859,7 @@
7 "version": "file:tests/selenium/wdio-mediawiki",
8 "dev": true,
9 "requires": {
10- "mwbot": "1.0.10"
11+ "mwbot": "2.0.0"
12 }
13 },
14 "wdio-video-reporter": {
15diff --git a/tests/selenium/wdio-mediawiki/package.json b/tests/selenium/wdio-mediawiki/package.json
16index 4bdb838427..66ea397cbf 100644
17--- a/tests/selenium/wdio-mediawiki/package.json
18+++ b/tests/selenium/wdio-mediawiki/package.json
19@@ -16,6 +16,6 @@
20 "node": ">=10.0"
21 },
22 "dependencies": {
23- "mwbot": "1.0.10"
24+ "mwbot": "2.0.0"
25 }
26 }
27
28
29
30~/Documents/gerrit/mediawiki/core$ npm run selenium-test
31
32> @ selenium-test /Users/z/Documents/gerrit/mediawiki/core
33> wdio ./tests/selenium/wdio.conf.js
34
35
36Execution of 6 spec files started at 2021-04-16T13:57:55.487Z
37
38[0-0] RUNNING in chrome - /tests/selenium/wdio-mediawiki/specs/BlankPage.js
39[0-0]
40 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/BlankPage-should-have-its-title-%40daily.png
41
42[0-0] PASSED in chrome - /tests/selenium/wdio-mediawiki/specs/BlankPage.js
43[0-1] RUNNING in chrome - /tests/selenium/specs/page.js
44[0-1] [15:58:00] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
45[0-1]
46 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-previewable.png
47
48[0-1]
49 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-creatable.png
50
51[0-1]
52 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-re-creatable.png
53
54[0-1]
55 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-editable-%40daily.png
56
57[0-1]
58 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-have-history-%40daily.png
59
60[0-1]
61 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-deletable.png
62
63[0-1]
64 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Page-should-be-restorable.png
65
66[0-1] PASSED in chrome - /tests/selenium/specs/page.js
67[0-2] RUNNING in chrome - /tests/selenium/specs/rollback.js
68[0-2] PASSED in chrome - /tests/selenium/specs/rollback.js
69[0-3] RUNNING in chrome - /tests/selenium/specs/specialrecentchanges.js
70[0-3] [15:58:32] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
71[0-3]
72 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Special%3ARecentChanges-shows-page-creation.png
73
74[0-3] PASSED in chrome - /tests/selenium/specs/specialrecentchanges.js
75[0-4] RUNNING in chrome - /tests/selenium/specs/specialwatchlist.js
76[0-4] [15:58:40] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
77[0-4]
78 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/Special%3AWatchlist-should-show-page-with-new-edit.png
79
80[0-4] PASSED in chrome - /tests/selenium/specs/specialwatchlist.js
81[0-5] RUNNING in chrome - /tests/selenium/specs/user.js
82[0-5] [15:58:53] [S] [MWBOT] Login successful: Admin@http://localhost:8080/w
83[0-5]
84 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/User-should-be-able-to-create-account.png
85
86[0-5]
87 Screenshot location: /Users/z/Documents/gerrit/mediawiki/core/tests/selenium/log/User-should-be-able-to-log-in-%40daily.png
88
89[0-5] PASSED in chrome - /tests/selenium/specs/user.js
90
91 "dot" Reporter:
92....................
93
94Spec Files: 6 passed, 6 total (100% completed) in 00:01:03

Related Objects

StatusSubtypeAssignedTask
OpenNone
Resolvedkostajh

Event Timeline

zeljkofilipin triaged this task as Medium priority.
zeljkofilipin moved this task from Inbox to Selenium on the MediaWiki-Core-Tests board.
zeljkofilipin moved this task from Backlog 🪒 to Deep work 🌊 on the User-zeljkofilipin board.
zeljkofilipin updated the task description. (Show Details)

Change 680336 had a related patch set uploaded (by Zfilipin; author: Zfilipin):

[mediawiki/core@master] WIP selenium: Update mwbot to v2

https://gerrit.wikimedia.org/r/680336

Change 680336 merged by jenkins-bot:

[mediawiki/core@master] selenium: Update mwbot to v2

https://gerrit.wikimedia.org/r/680336

kostajh subscribed.

Can we track Wikibase upgrades here as well, or do we want a separate task? I created https://github.com/wmde/wdio-wikibase/pull/36 and can make package.json updates for the sub-repos as well.

Change 693400 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/core@master] wdio-mediawiki: Bump package version

https://gerrit.wikimedia.org/r/693400

Change 693400 merged by jenkins-bot:

[mediawiki/core@master] wdio-mediawiki: Release 1.1.0

https://gerrit.wikimedia.org/r/693400

kostajh claimed this task.

@kostajh can this task be resolved?

Sounds good to me!