Page MenuHomePhabricator
Create Task
Maniphest T280762

Icon placement in reference previews is broken (again)
Closed, ResolvedPublic
Actions

Description

Screenshot from 2021-04-21 11-07-43.png (244×397 px, 24 KB)

I assume this is because of an upstream change in either OOUI or core.

See previous work in T221555: Decrease size and fix alignment of icon in reference preview panel.

Details

SubjectRepoBranchLines +/-
Minimize and optimize reference preview CSSmediawiki/extensions/Popupsmaster+29 -28
Fix icon placement in reference previewsmediawiki/extensions/Popupsmaster+7 -2
Customize query in gerrit

Related Objects

Event Timeline

thiemowmde created this task.Apr 21 2021, 9:10 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 21 2021, 9:10 AM
thiemowmde added a project: Unplanned-Sprint-Work.Apr 21 2021, 9:10 AM
thiemowmde moved this task from Backlog to Doing on the Reference Previews board.
thiemowmde added a subscriber: Lena_WMDE.
awight updated the task description. (Show Details)Apr 21 2021, 10:30 AM
gerritbot added a comment.Apr 21 2021, 10:30 AM

Change 681606 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Fix icon placement in reference previews

https://gerrit.wikimedia.org/r/681606

gerritbot added a project: Patch-For-Review.Apr 21 2021, 10:30 AM
thiemowmde added a subscriber: Volker_E.Apr 21 2021, 10:31 AM

I did a git bisect and found the responsible patch in core, not OOUI: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/673034.

thiemowmde claimed this task.Apr 21 2021, 10:31 AM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-TechWish-Sprint-2021-04-14 board.
gerritbot added a comment.Apr 21 2021, 10:38 AM

Change 664784 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Minimize and optimize reference preview CSS

https://gerrit.wikimedia.org/r/664784

gerritbot added a comment.Apr 22 2021, 2:38 PM

Change 681606 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix icon placement in reference previews

https://gerrit.wikimedia.org/r/681606

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 22 2021, 3:00 PM
thiemowmde moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 26 2021, 7:07 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 27 2021, 8:37 AM
Lena_WMDE closed this task as Resolved.Apr 27 2021, 8:39 AM
gerritbot added a comment.May 3 2021, 11:43 AM

Change 664784 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Minimize and optimize reference preview CSS

https://gerrit.wikimedia.org/r/664784

ReleaseTaggerBot edited projects, added MW-1.37-notes (1.37.0-wmf.4; 2021-05-04); removed MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).May 3 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 3 2021, 12:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL