Page MenuHomePhabricator
Create Task
Maniphest T280984

WikibaseRepo: Remove getDefaultInstance()
Closed, ResolvedPublic
Actions

Description

newInstance can possibly be removed as well.

Migration path: replace (for instance)

$wbRepo = Wikibase\Repo\WikibaseRepo::getDefaultInstance();
$entityIdLookup = $wbRepo->getEntityIdLookup();

by

$entityIdLookup = Wikibase\Repo\WikibaseRepo::getEntityIdLookup();

Details

SubjectRepoBranchLines +/-
Remove WikibaseRepo::getDefaultInstance() stubmediawiki/extensions/Citoidmaster+0 -3
Remove getDefaultInstance and newInstance from WikibaseRepomediawiki/extensions/Wikibasemaster+0 -23
Remove WikibaseRepo::getDefaultInstance()mediawiki/extensions/WikibaseMediaInfomaster+2 -6
Remove WikibaseRepo::getDefaultInstance() callsmediawiki/extensions/Mathmaster+0 -1
Remove WikibaseRepo::getDefaultInstance() calls from WikibaseLexememediawiki/extensions/WikibaseLexememaster+2 -22
Remove WikibaseRepo::getDefaultInstance() callsmediawiki/extensions/WikibaseManifestmaster+1 -2
Remove WikibaseRepo::getDefaultInstance()mediawiki/extensions/WikibaseLexemeCirrusSearchmaster+3 -5
Remove WikibaseRepo::getDefaultInstance() callsmediawiki/extensions/WikibaseCirrusSearchmaster+1 -5
Remove WikibaseRepo::getDefaultInstance() callsmediawiki/extensions/WikibaseQualityConstraintsmaster+1 -4
Remove calls to getDefaultInstance from WikibaseRepomediawiki/extensions/Wikibasemaster+5 -59
Customize query in gerrit

Related Objects

Event Timeline

ItamarWMDE created this task.Apr 23 2021, 3:31 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 23 2021, 3:31 PM
ItamarWMDE updated the task description. (Show Details)Apr 23 2021, 3:35 PM
ItamarWMDE mentioned this in T280985: WikibaseRepo: Remove constructor.
ItamarWMDE updated the task description. (Show Details)
ItamarWMDE mentioned this in T280986: WikibaseRepo:: Remove resetClassStatics.Apr 23 2021, 3:38 PM
Rosalie_WMDE claimed this task.Apr 23 2021, 7:15 PM
Rosalie_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 23 2021, 7:35 PM

Change 682195 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove getDefaultInstance from WikibaseRepo

https://gerrit.wikimedia.org/r/682195

gerritbot added a project: Patch-For-Review.Apr 23 2021, 7:35 PM
gerritbot added a comment.Apr 27 2021, 2:01 PM

Change 682951 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove getDefaultInstance and newInstance from WikibaseRepo

https://gerrit.wikimedia.org/r/682951

Rosalie_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 27 2021, 2:02 PM
gerritbot added a comment.Apr 27 2021, 4:43 PM

Change 682195 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove calls to getDefaultInstance from WikibaseRepo

https://gerrit.wikimedia.org/r/682195

Rosalie_WMDE moved this task from Up for review to Doing on the Wikibase Service Migration board.Apr 27 2021, 4:48 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.4; 2021-05-04).Apr 27 2021, 5:00 PM
gerritbot added a comment.Apr 28 2021, 11:30 AM

Change 683261 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Remove WikibaseRepo::getDefaultInstance() calls from WikibaseLexeme

https://gerrit.wikimedia.org/r/683261

gerritbot added a comment.Apr 28 2021, 1:07 PM

Change 683273 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683273

gerritbot added a comment.Apr 28 2021, 2:38 PM

Change 683298 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove WikibaseRepo::getDefaultInstance() calls from

https://gerrit.wikimedia.org/r/683298

gerritbot added a comment.Apr 28 2021, 2:46 PM

Change 683347 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683347

gerritbot added a comment.Apr 28 2021, 3:58 PM

Change 683368 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Remove WikibaseRepo::getDefaultInstance()

https://gerrit.wikimedia.org/r/683368

gerritbot added a comment.Apr 28 2021, 4:03 PM

Change 683369 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/WikibaseManifest@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683369

gerritbot added a comment.Apr 28 2021, 4:15 PM

Change 683298 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683298

gerritbot added a comment.Apr 28 2021, 4:36 PM

Change 683374 had a related patch set uploaded (by Rosalie Perside (WMDE); author: Rosalie Perside (WMDE)):

[mediawiki/extensions/Math@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683374

gerritbot added a comment.Apr 28 2021, 5:09 PM

Change 683261 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Remove WikibaseRepo::getDefaultInstance() calls from WikibaseLexeme

https://gerrit.wikimedia.org/r/683261

gerritbot added a comment.Apr 28 2021, 5:09 PM

Change 683347 merged by jenkins-bot:

[mediawiki/extensions/WikibaseCirrusSearch@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683347

gerritbot added a comment.Apr 28 2021, 5:09 PM

Change 683368 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Remove WikibaseRepo::getDefaultInstance()

https://gerrit.wikimedia.org/r/683368

Rosalie_WMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 28 2021, 5:12 PM
gerritbot added a comment.Apr 28 2021, 5:19 PM

Change 683369 merged by jenkins-bot:

[mediawiki/extensions/WikibaseManifest@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683369

Rosalie_WMDE mentioned this in rEWBN8e2511bec2fc: Remove WikibaseRepo::getDefaultInstance() calls.Apr 28 2021, 5:19 PM
Rosalie_WMDE mentioned this in rEWLC46b035ac64e3: Remove WikibaseRepo::getDefaultInstance().Apr 28 2021, 5:40 PM
gerritbot added a comment.Apr 28 2021, 5:45 PM

Change 683374 merged by jenkins-bot:

[mediawiki/extensions/Math@master] Remove WikibaseRepo::getDefaultInstance() calls

https://gerrit.wikimedia.org/r/683374

gerritbot added a comment.Apr 29 2021, 10:16 AM

Change 683273 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Remove WikibaseRepo::getDefaultInstance()

https://gerrit.wikimedia.org/r/683273

gerritbot added a comment.Apr 29 2021, 12:18 PM

Change 682951 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove getDefaultInstance and newInstance from WikibaseRepo

https://gerrit.wikimedia.org/r/682951

Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 29 2021, 1:57 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
gerritbot added a comment.Apr 29 2021, 2:36 PM

Change 683652 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Citoid@master] Remove WikibaseRepo::getDefaultInstance() stub

https://gerrit.wikimedia.org/r/683652

gerritbot added a comment.Apr 29 2021, 4:51 PM

Change 683652 merged by jenkins-bot:

[mediawiki/extensions/Citoid@master] Remove WikibaseRepo::getDefaultInstance() stub

https://gerrit.wikimedia.org/r/683652

Seb35 updated the task description. (Show Details)May 3 2021, 2:22 PM
Seb35 subscribed.May 3 2021, 2:25 PM

I added the migration path in the description since I was wondering what it was when I tried to upgrade the extension RecordWizard for 1.37.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits