Instead, it’s probably better to directly inject an ILoadBalancer into the constructor. (The class should probably also directly implement IDBAccessObject, previously implemented via DBAccessBase, in case any other code relies on it.)
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Inject ILoadBalancer into SqlSiteLinkConflictLookup | mediawiki/extensions/Wikibase | master | +22 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • Lucas_Werkmeister_WMDE | T279063 Deprecate and remove DBAccessBase class | |||
| Resolved | • Lucas_Werkmeister_WMDE | T281118 Stop using DBAccessBase in SqlSiteLinkConflictLookup |
Event Timeline
Comment Actions
The class should probably also directly implement IDBAccessObject, previously implemented via DBAccessBase, in case any other code relies on it.
Not sure about this part, on second thought. The class doesn’t seem to support the READ_* constants, so I don’t see why it should implement the interface providing those constants.
Comment Actions
Change 682670 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Inject ILoadBalancer into SqlSiteLinkConflictLookup
Comment Actions
Change 682671 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Remove isRepoEnabled() checks in repo tests
Comment Actions
Change 682670 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Inject ILoadBalancer into SqlSiteLinkConflictLookup