Page MenuHomePhabricator

annotation not found for offset
Closed, ResolvedPublic

Description

Possibly fallout from the switch to a toolbar dialog from T267706: Add a link in VE: Use a permanent context instead of VE's built-in context. This error occurs when toggling yes/no on link suggestions:

annotation not found for offset 279 load.php:7:814
    getAnnotationStates load.php:7
    getAnnotationStates load.php:7
    isSaveable load.php:7
    onUpdateState load.php:48807
    updateToolbarSaveButtonState load.php:985
    emit jQuery
    changeInternal load.php:9141
    change load.php:9092
    change load.php:9513
    annotateContent load.php:9867
    setAccepted load.php:24
    jQuery 8
    setAccepted load.php:24
    onYesButtonClicked load.php:22
    jQuery 16
    setupButtons load.php:28
    initialize load.php:20
    initialize load.php:41
    jQuery 3
    open load.php:28551
    jQuery 3
    open load.php:28550
    jQuery 8
    open load.php:28546
    toggle load.php:28619
    executeWithSource load.php:24136
    execute load.php:25143
    executeCommand load.php:24145
    selectFirstRecommendation load.php:3
    jQuery 7
    afterSurfaceReady load.php:2
    surfaceReady load.php:39
    addSurface load.php:37258
    (Async: setTimeout handler)
    addSurface load.php:37253
    addSurface load.php:33067
    setupSurface load.php:37240
    (Async: setTimeout handler)
    setupSurface load.php:37239
    (Async: setTimeout handler)
    setupSurface load.php:37231
    documentReady load.php:37184

Event Timeline

kostajh triaged this task as Medium priority.Apr 29 2021, 9:38 AM
kostajh created this task.

Change 683562 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[mediawiki/extensions/GrowthExperiments@master] AddLink: Avoid throwing errors when storeHashes don't exist

https://gerrit.wikimedia.org/r/683562

Change 683562 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] AddLink: No-op updateToolbarSaveButtonState

https://gerrit.wikimedia.org/r/683562

Etonkovidova subscribed.

Checked in betalabs (yesterday (Apr 29) the issue was displayed in the Console) - moving the task to Verify in production.

Checked in wmf.7 - the errors were not present.