Load modules and settings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Sebastian_Berlin-WMSE
	May 3 2021, 7:20 AM

Description

Loading for modules (Javascript and CSS) and settings need to be loaded for the gadget. ResourceLoader can not be used for this, instead this needs to be done in a module. Cleanest way is probably to create new module (gadget loader) that takes care of all this and calls ext.wikispeech.main.

Global settings, i.e. those in the extension config, can live on the producer. These will be the defaults, possibly they could be overwritten by settings stored on the consumer. Same goes for default user settings.

Details

	Subject	Repo	Branch	Lines +/-
	Run Wikispeech as a gadget	mediawiki/extensions/Wikispeech	master	+419 -89

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Sebastian_Berlin-WMSE	T281662 ☂Enable running Wikispeech via gadget
		Resolved		Sebastian_Berlin-WMSE	T281665 Load modules and settings

Event Timeline

Sebastian_Berlin-WMSE created this task.May 3 2021, 7:20 AM

Sebastian_Berlin-WMSE updated the task description. (Show Details)May 3 2021, 7:25 AM

Sebastian_Berlin-WMSE claimed this task.May 3 2021, 11:38 AM

Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE.

Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.

The config and default user options were possible to load using ResourceLoader. That means they will be up to date with any changes in extension.json automatically.

I'm having an issue with loading the ext.wikispeech module. For some reason, I can't use mw.loader.using() in the gadget script; it never triggers. When I call it in the console after loading the script it does work. This means that there is a race condition where the gadget script crashes if the ext.wikispeech module hasn't loaded.

It looks like this is solved by registering the module with mw.loader.register() and passing "anotherwiki" as source. There is now a GET request on the consumer that looks something like this:
https://sv.wikipedia.org/wiki/undefined?lang=sv&modules=ext.wikispeech&skin=vector&version=ztntf which returns error 404 (unsurprisingly). Not sure what does that exactly, but it doesn't seem to actually break anything.