Page MenuHomePhabricator
Create Task
Maniphest T281961

AddLinkArticleTarget toolbar does not display properly
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Click on a link recommendation task for a shorter article; or on a longer article scroll down

What happens?:

image.png (1×3 px, 784 KB)

and

image.png (456×1 px, 135 KB)

What should have happened instead?:

The toolbar should not go above the page/discussion tabs, like in normal visual edit mode:

image.png (456×1 px, 67 KB)

Also, the z-index for the toolbar dialog might need to be adjusted.

Details

SubjectRepoBranchLines +/-
Add a link: update scroll offset & z-indexmediawiki/extensions/GrowthExperimentsmaster+5 -1
Customize query in gerrit

Related Objects

Event Timeline

kostajh created this task.May 5 2021, 7:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2021, 7:11 AM
kostajh triaged this task as Medium priority.May 5 2021, 7:11 AM
kostajh moved this task from Backlog to May 3 - May 7 on the Add-Link board.
kostajh moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh renamed this task from Broken toolbar display on shorter articles to AddLinkArticleTarget toolbar does not display properly.May 5 2021, 10:43 AM
kostajh updated the task description. (Show Details)
kostajh raised the priority of this task from Medium to High.May 5 2021, 10:45 AM
kostajh assigned this task to • mewoph.May 5 2021, 11:35 AM
kostajh added a subscriber: • mewoph.

Tenatively assigning to @mewoph, feel free to unassign if you don't think you could get to it this week.

• mewoph added a comment.EditedMay 5 2021, 5:04 PM

The floating state of the toolbar should only be applied when the page is scrolled. It looks like the value of toolbarScrollOffset is too high, decreasing this value seems to fix the issue.

gerritbot added a comment.May 5 2021, 5:19 PM

Change 685532 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: update scroll offset & z-index

https://gerrit.wikimedia.org/r/685532

gerritbot added a project: Patch-For-Review.May 5 2021, 5:19 PM
• mewoph added a comment.May 5 2021, 5:19 PM

Same article w/latest changes:

Screen Shot 2021-05-05 at 10.15.52 AM.png (1×2 px, 856 KB)

• mewoph moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.May 5 2021, 5:20 PM
kostajh moved this task from May 3 - May 7 to Done / QA on the Add-Link board.May 5 2021, 8:18 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.May 5 2021, 8:29 PM

Change 685532 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: update scroll offset & z-index

https://gerrit.wikimedia.org/r/685532

Maintenance_bot removed a project: Patch-For-Review.May 5 2021, 9:10 PM
Etonkovidova closed this task as Resolved.EditedMay 8 2021, 12:45 AM
Etonkovidova subscribed.

Checked in betalabs - the issues are fixed.

• mewoph mentioned this in T282579: Add a link: transparent link inspector.May 11 2021, 8:23 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL