Page MenuHomePhabricator

Add a link: Yes button flickers when toggling states
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Enable link recommendations
  • Accept recommendation
  • Un-accept recommendation

What happens?:
The button flickers before showing toggled/untoggled state.

What should have happened instead?:
The button state should be updated without flickering.

addlink_flicker.gif (880×1 px, 317 KB)

Event Timeline

Change 685538 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: don't reset button states when toggling

https://gerrit.wikimedia.org/r/685538

Change 685538 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: don't reset button states when toggling

https://gerrit.wikimedia.org/r/685538

Etonkovidova added a subscriber: Etonkovidova.

Checked in betalabs - below is animated gifs to compare (betalabs with the fix vs production without the fix)

betalabs(click to animate)testwiki (click to animate)
flicker_button.gif (266×405 px, 27 KB)
flicker3_button.gif (275×453 px, 37 KB)