Add a link: Yes button flickers when toggling states
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	• mewoph
	May 5 2021, 5:31 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The button flickers before showing toggled/untoggled state.

What should have happened instead?:
The button state should be updated without flickering.

	Subject	Repo	Branch	Lines +/-
	Add a link: don't reset button states when toggling	mediawiki/extensions/GrowthExperiments	master	+6 -1

Mentioned In: T282175: Add link: an image placeholder flickers when Yes button clicked

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 5 2021, 5:31 PM

• mewoph moved this task from Backlog to May 3 - May 7 on the Add-Link board.

Change 685538 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add a link: don't reset button states when toggling

With latest changes:

Change 685538 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add a link: don't reset button states when toggling

Checked in betalabs - below is animated gifs to compare (betalabs with the fix vs production without the fix)

betalabs(click to animate)	testwiki (click to animate)

	F34443960: flicker3_button.gif
	May 6 2021, 6:10 PM

	F34443956: flicker_button.gif
	May 6 2021, 6:10 PM