TypeError: Cannot read property 'top' of undefined
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	May 11 2021, 7:39 PM

Description

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.05.11?id=XhSeXHkBg_6mGHGhYrgD

TypeError: Cannot read property 'top' of undefined

at Object.handleKeyDown  https://es.wikipedia.org/w/load.php?lang=es&modules=ext.wikiEditor&skin=vector&version=j6u37:30:557
at HTMLDivElement.<anonymous>  https://es.wikipedia.org/w/load.php?lang=es&modules=ext.wikiEditor&skin=vector&version=j6u37:28:484
at HTMLDivElement.dispatch  https://es.wikipedia.org/w/load.php?lang=es&modules=jquery%2Cmoment%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=w1d25:70:214
at HTMLDivElement.elemData.handle  https://es.wikipedia.org/w/load.php?lang=es&modules=jquery%2Cmoment%2Coojs-ui-core%2Coojs-ui-widgets%7Cjquery.ui&skin=vector&version=w1d25:66:848

Details

	Subject	Repo	Branch	Lines +/-
	Avoid "Cannot read property 'top' of undefined" in toolbar	mediawiki/extensions/WikiEditor	master	+2 -1

Customize query in gerrit

Event Timeline

Jdlrobson created this task.May 11 2021, 7:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 11 2021, 7:39 PM

Reported sample URL is like: https://simple.wikipedia.org/w/index.php?title=*&action=edit&redlink=1

Assuming old for stats, since this code has not been actively developed for several years. Note that this does not set the priority.

To reproduce

open page in source editor
press "special characters"
scroll in the left panel with the modes
press the key up or down
error

Change 697141 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikiEditor@master] Avoid "Cannot read property 'top' of undefined"

https://gerrit.wikimedia.org/r/697141

gerritbot added a project: Patch-For-Review.May 29 2021, 5:01 PM

Change 697141 merged by jenkins-bot:

[mediawiki/extensions/WikiEditor@master] Avoid "Cannot read property 'top' of undefined" in toolbar

https://gerrit.wikimedia.org/r/697141

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.9; 2021-06-07).Jun 1 2021, 10:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jun 1 2021, 10:10 PM

Umherirrender closed this task as Resolved.Jun 2 2021, 7:06 PM

Umherirrender claimed this task.

happy5214 moved this task from Backlog to Closed on the WikiEditor board.Jul 17 2021, 5:20 AM

TypeError: Cannot read property 'top' of undefinedClosed, ResolvedPublicActions

Description

Details

Event Timeline

TypeError: Cannot read property 'top' of undefined
Closed, ResolvedPublic
Actions