Page MenuHomePhabricator
Create Task
Maniphest T283499

Schema change for renaming page_timestamp index on revision table to rev_page_timestamp
Closed, ResolvedPublic
Actions

Description

Part of T270033: Fix and enforce table prefix usage in columns and indexes in core and T230428: Migrate tables.sql to abstract schema

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/674138/6/maintenance/archives/patch-revision-rename-index.sql
  2. Where to run those changes: all.dblist
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: Tested in beta cluster.
  6. if the data should be made available on the labs replicas and/or dumps: public, replicated to the cloud

Progress

  • s2
    • eqiad
    • codfw
  • s3
    • eqiad
    • codfw
  • s4
    • eqiad
    • codfw
  • s5
    • eqiad
    • codfw
  • s6
    • eqiad
    • codfw
  • s7
    • eqiad
    • codfw
  • s8
    • eqiad
    • codfw
  • labswiki
  • labtestwiki

Related Objects
Search...

Event Timeline

Ladsgroup created this task.May 24 2021, 12:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMay 24 2021, 12:36 PM
LSobanski assigned this task to • Kormat.May 26 2021, 6:24 PM
LSobanski triaged this task as Medium priority.
LSobanski moved this task from Triage to Pending comment on the DBA board.
LSobanski subscribed.

Assigning to Stevie to confirm if this can go into Ready.

• Kormat removed • Kormat as the assignee of this task.May 27 2021, 9:30 AM
• Kormat moved this task from Pending comment to Ready on the DBA board.
• Kormat subscribed.
Marostegui added a parent task: T285139: DB maintenance work to do while eqiad is passive (June 2021).Jun 18 2021, 11:19 AM
Marostegui claimed this task.Jun 21 2021, 11:51 AM
Stashbot added a comment.Jun 21 2021, 11:51 AM

Mentioned in SAL (#wikimedia-operations) [2021-06-21T11:51:44Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1135 T283499', diff saved to https://phabricator.wikimedia.org/P16662 and previous config saved to /var/cache/conftool/dbconfig/20210621-115143-marostegui.json

Stashbot added a comment.Jun 21 2021, 11:54 AM

Mentioned in SAL (#wikimedia-operations) [2021-06-21T11:54:42Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1099:3311 T283499', diff saved to https://phabricator.wikimedia.org/P16664 and previous config saved to /var/cache/conftool/dbconfig/20210621-115441-marostegui.json

Marostegui added a comment.Jun 21 2021, 11:56 AM

Altered db1099:3311 and db1135 on enwiki, let's see if we find some queries forcing that index.

root@cumin1001:/home/marostegui/T283499# for i in db1135 db1099:3311; do echo $i; mysql.py -h$i enwiki -e "show create table revision\G" | grep page_timestamp
> done
db1135
  KEY `rev_page_timestamp` (`rev_page`,`rev_timestamp`)
db1099:3311
  KEY `rev_page_timestamp` (`rev_page`,`rev_timestamp`)
Marostegui moved this task from Backlog to In progress on the Schema-change-in-production board.Jun 21 2021, 11:56 AM
Marostegui moved this task from Ready to In progress on the DBA board.
Stashbot added a comment.Jun 22 2021, 7:28 AM

Mentioned in SAL (#wikimedia-operations) [2021-06-22T07:28:29Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depool db1169 T283499', diff saved to https://phabricator.wikimedia.org/P16678 and previous config saved to /var/cache/conftool/dbconfig/20210622-072828-marostegui.json

Marostegui added a comment.Jun 22 2021, 8:31 AM

So far I haven't seen any errors coming from queries forcing this specific index, so I have change it on db1169 as well. If nothing happens in the next 24h, we can proceed with this task:

root@db1169.eqiad.wmnet[enwiki]> DROP  INDEX page_timestamp ON  /*_*/revision;
Query OK, 0 rows affected (0.194 sec)
Records: 0  Duplicates: 0  Warnings: 0

root@db1169.eqiad.wmnet[enwiki]> CREATE INDEX rev_page_timestamp ON  /*_*/revision (rev_page, rev_timestamp);
Stage: 1 of 1 'Altering table'    100% of stage donee


Query OK, 0 rows affected (1 hour 9.347 sec)
Records: 0  Duplicates: 0  Warnings: 0
Marostegui added a comment.Jul 2 2021, 6:41 AM

I think this can go

Ladsgroup added a comment.Jul 2 2021, 9:40 AM

YAY

Marostegui updated the task description. (Show Details)Jul 6 2021, 9:50 AM
Marostegui added a comment.EditedJul 6 2021, 11:13 AM

s1 eqiad

  • dbstore1003
  • db1184
  • db1169
  • db1164
  • db1163
  • db1154
  • db1140
  • db1139
  • db1135
  • db1134
  • db1133
  • db1119
  • db1118
  • db1106
  • db1105
  • db1099
  • clouddb1021
  • clouddb1017
  • clouddb1013
  • db2146
  • db2145
  • db2141
  • db2130
  • db2116
  • db2112
  • db2103
  • db2102
  • db2097
  • db2094
  • db2092
  • db2088
  • db2085
  • db2072
  • db2071
Marostegui updated the task description. (Show Details)Jul 6 2021, 11:13 AM
Marostegui updated the task description. (Show Details)Jul 7 2021, 6:42 AM
Marostegui updated the task description. (Show Details)Jul 7 2021, 6:45 AM
Marostegui updated the task description. (Show Details)Jul 7 2021, 9:23 AM
Marostegui updated the task description. (Show Details)Jul 7 2021, 11:02 AM
Marostegui updated the task description. (Show Details)Jul 7 2021, 12:31 PM
Marostegui updated the task description. (Show Details)Jul 7 2021, 4:17 PM
Marostegui updated the task description. (Show Details)Jul 8 2021, 5:02 AM
Marostegui updated the task description. (Show Details)Jul 8 2021, 5:16 AM
Marostegui updated the task description. (Show Details)Jul 8 2021, 10:47 AM
Marostegui moved this task from In progress to Unclear/blocked to proceed on the Schema-change-in-production board.

eqiad is done, waiting for the switch back to complete codfw.

Marostegui changed the task status from Open to Stalled.Jul 8 2021, 10:49 AM
Marostegui moved this task from In progress to Blocked on the DBA board.
Marostegui updated the task description. (Show Details)Jul 9 2021, 4:54 AM
Marostegui changed the task status from Stalled to Open.Sep 28 2021, 5:28 AM
Marostegui moved this task from Unclear/blocked to proceed to In progress on the Schema-change-in-production board.Sep 28 2021, 5:30 AM
Marostegui moved this task from Blocked to In progress on the DBA board.
Marostegui updated the task description. (Show Details)Sep 28 2021, 8:22 AM
Stashbot added a comment.Sep 28 2021, 9:23 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T09:23:57Z] <marostegui> Deploy schema change on s2 codfw (lag will show up) T283499

Marostegui updated the task description. (Show Details)Sep 28 2021, 9:24 AM
Stashbot added a comment.Sep 28 2021, 9:26 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T09:26:39Z] <marostegui> Deploy schema change on s4 codfw (lag will show up) T283499

Marostegui updated the task description. (Show Details)Sep 28 2021, 9:26 AM
Marostegui updated the task description. (Show Details)Sep 28 2021, 9:54 AM
Stashbot added a comment.Sep 28 2021, 10:00 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T10:00:55Z] <marostegui> Deploy schema change on s7 codfw (lag will show up) T283499

Stashbot added a comment.Sep 28 2021, 10:01 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T10:01:42Z] <marostegui> Deploy schema change on s5 codfw (lag will show up) T283499

Marostegui updated the task description. (Show Details)Sep 28 2021, 11:24 AM
Stashbot added a comment.Sep 28 2021, 11:25 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T11:25:47Z] <marostegui> Deploy schema change on s6 codfw (lag will show up) T283499

Marostegui updated the task description. (Show Details)Sep 28 2021, 11:26 AM
Stashbot added a comment.Sep 28 2021, 11:29 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-28T11:29:57Z] <marostegui> Deploy schema change on s3 codfw (lag will show up) T283499

Marostegui updated the task description. (Show Details)Sep 28 2021, 11:48 AM
Stashbot added a comment.Sep 29 2021, 6:15 AM

Mentioned in SAL (#wikimedia-operations) [2021-09-29T06:15:12Z] <marostegui> Deploy schema change on s8 codfw (lag will show up) T283499

Marostegui closed this task as Resolved.Sep 29 2021, 11:50 AM
Marostegui updated the task description. (Show Details)

All done

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits