Page MenuHomePhabricator

Translation units to be deleted appear with unit ID -1 on Special:PageTranslation
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Remove a translation unit from a page already in translation.
  2. Try to mark it again for translation.
  3. Look at the Deleted translation units section.

Actual result

  1. The deleted translation unit appears with unit ID -1.
    Screenshot_2021-05-29 Page translation - Meta.png (705×653 px, 39 KB)

Expected result

  1. The deleted translation unit appears with its actual unit ID. For example, on the above screenshot, Recent changes’ ID is 3, which appears correctly in the diff.

Event Timeline

Change 705882 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] PageTranslation: Fix unit id always showing as -1 for deleted sections

https://gerrit.wikimedia.org/r/705882

Change 705882 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] PageTranslation: Fix unit id always showing as -1 for deleted sections

https://gerrit.wikimedia.org/r/705882

abi_ added a subscriber: abi_.

This is fixed. Tested on Mediawiki.org.

image.png (904×1 px, 106 KB)