Maniphest T284674

Add test cases for STV [M]
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Niharika
	Jun 9 2021, 4:04 PM

Tags

Referenced Files

None

Subscribers

Description

Motivation

This task is to collect and add different test cases to test STV in the code.

Acceptance criteria

Come up with test cases
Add them to the the codebase to test STV

Presumably the edge cases come up as QA happens but at the very least, the STVTallierTest.php should exist and have a testSTVTally function that uses a dataProvider to ingest an array of votes and has an expected output detailing the tally results.

Details

	Subject	Repo	Branch	Lines +/-
	Add test cases for STV	mediawiki/extensions/SecurePoll	master	+22 K -2

Customize query in gerrit

Event Timeline

Niharika triaged this task as Medium priority.Jun 9 2021, 4:04 PM

Niharika created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 9 2021, 4:04 PM

ARamirez_WMF renamed this task from Add test cases for STV to Add test cases for STV [M].Jun 9 2021, 4:39 PM

ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment board.

STran updated the task description. (Show Details)Jun 9 2021, 5:05 PM

ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jul 19 2021, 6:26 PM

ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

ARamirez_WMF moved this task from The Letter Song to Cards ready for development on the Anti-Harassment board.

ARamirez_WMF edited projects, added Anti-Harassment; removed Anti-Harassment (The Letter Song).

• TThoabala claimed this task.Jul 20 2021, 2:57 PM

• TThoabala moved this task from Cards ready for development to The Letter Song on the Anti-Harassment board.Jul 20 2021, 4:15 PM

• TThoabala edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

• wikitrent moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Jul 20 2021, 4:16 PM

Change 710245 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/SecurePoll@master] Add test cases for STV

https://gerrit.wikimedia.org/r/710245

gerritbot added a project: Patch-For-Review.Aug 5 2021, 12:03 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Aug 5 2021, 2:43 PM

• wikitrent moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment (The Letter Song) board.Aug 5 2021, 3:49 PM

• TThoabala moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Aug 5 2021, 7:19 PM

Change 710245 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Add test cases for STV

https://gerrit.wikimedia.org/r/710245

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 11 2021, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 11 2021, 12:10 PM

ARamirez_WMF moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Aug 11 2021, 4:17 PM

ARamirez_WMF moved this task from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.

Niharika closed this task as Resolved.Aug 16 2021, 11:15 PM