Page MenuHomePhabricator
Create Task
Maniphest T285454

Introduce and Test a FederatedPropertyAwareDispatchingIdParser
Closed, ResolvedPublic
Actions

Description

  • create a FederatedPropertyAwareDispatchingEntityIdParser (or find a snappier name!) that wraps DispatchingEntityIdParser and creates new federated property ids from serialization or * * delegates to DispatchingEntityIdParser if the serialization is not a URI. The new parser can either directly create the new id objects or use a builder callback.
  • use FederatedPropertyAwareDispatchingEntityIdParser instead of DispatchingEntityIdParser if federated properties is enabled (and the inverse; i.e. don't instantiate this service if FeddyProps isn't enabled)
  • FederatedPropertyAwareDispatchingEntityIdParser validates the concept URI and checks whether there is an entity source defined for that concept URI

Details

SubjectRepoBranchLines +/-
FP: Wire FederatedPropertiesAwareDispatchingEntityIdParsermediawiki/extensions/Wikibasemaster+75 -1
FP: Create FederatedPropertiesAwareDispatchingEntityIdParsermediawiki/extensions/Wikibasemaster+279 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tarrow created this task.Jun 24 2021, 8:27 AM

blocked by T285453

• Tonina_Zhelyazkova_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jun 24 2021, 2:00 PM
Tarrow assigned this task to • Tonina_Zhelyazkova_WMDE.Jun 24 2021, 2:02 PM
gerritbot added a comment.Jun 25 2021, 9:07 AM

Change 701390 had a related patch set uploaded (by Tarrow; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Create FederatedPropertiesAwareDispatchingEntityIdParser

https://gerrit.wikimedia.org/r/701390

gerritbot added a project: Patch-For-Review.Jun 25 2021, 9:07 AM

Change 701491 had a related patch set uploaded (by Tarrow; author: Tonina Zhelyazkova):

[mediawiki/extensions/Wikibase@master] FP: Wire FederatedPropertiesAwareDispatchingEntityIdParser

https://gerrit.wikimedia.org/r/701491

• Tonina_Zhelyazkova_WMDE reassigned this task from • Tonina_Zhelyazkova_WMDE to Tarrow.Jun 28 2021, 1:35 PM
• Tonina_Zhelyazkova_WMDE subscribed.
gerritbot added a comment.Jun 30 2021, 1:24 PM

Change 701390 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Create FederatedPropertiesAwareDispatchingEntityIdParser

https://gerrit.wikimedia.org/r/701390

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.14; 2021-07-12).Jun 30 2021, 2:00 PM
Tarrow moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.Jul 1 2021, 9:31 AM
gerritbot added a comment.Jul 1 2021, 10:27 AM

Change 701491 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: Wire FederatedPropertiesAwareDispatchingEntityIdParser

https://gerrit.wikimedia.org/r/701491

Rosalie_WMDE removed a project: Patch-For-Review.Jul 1 2021, 10:56 AM
Rosalie_WMDE moved this task from Peer Review to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 1) board.
Addshore closed this task as Resolved.Jul 16 2021, 11:03 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL