Page MenuHomePhabricator

Remove RUM Speed Index from the Navigation Timing extension
Closed, ResolvedPublic

Description

We added the RUM Speed Index many years ago to test if it could give us better metrics, but the thing is that the RUM version of Speed Index missed out on calculating correct Speed Index when we are showing a banner. A lot have happened since then and Chrome(ium)-browsers support Largest Contentful Paint (see T281022).

Let us remove RUM-Speed Index since we do not use it, the metric aren't correct and we can decrease the number of lines of code in the extension.

Event Timeline

Change 715496 had a related patch set uploaded (by Phedenskog; author: Peter Hedenskog):

[mediawiki/extensions/NavigationTiming@master] Remove RUM Speed Index.

https://gerrit.wikimedia.org/r/715496

Change 715496 merged by jenkins-bot:

[mediawiki/extensions/NavigationTiming@master] Remove RUM Speed Index.

https://gerrit.wikimedia.org/r/715496

Next: Clean up any server-side instrumentation / pipelines for this.

Change 726852 had a related patch set uploaded (by Phedenskog; author: Peter Hedenskog):

[operations/puppet@production] Eventlogging: Remove unused RUM Speed Index.

https://gerrit.wikimedia.org/r/726852

Change 726854 had a related patch set uploaded (by Phedenskog; author: Peter Hedenskog):

[operations/mediawiki-config@master] Remove unused RUM-SpeedIndex.

https://gerrit.wikimedia.org/r/726854

@Peter The config patch needs a rebase to resolve a merge conflict. I have +1'ed it however, which is equivalent of +2 for configuration patches. After that you can schedule it for deployment via https://wikitech.wikimedia.org/wiki/Deployments at a time where you're available to confirm no errors before and after via WikimediaDebug when the deployment window comes around.

Change 726854 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove unused eventlogging_RUMSpeedIndex stream

https://gerrit.wikimedia.org/r/726854

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:04:28Z] <ladsgroup@deploy1002> Started scap: Backport for [[gerrit:726854|Remove unused eventlogging_RUMSpeedIndex stream (T286700)]]

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:06:17Z] <ladsgroup@deploy1002> phedenskog and ladsgroup: Backport for [[gerrit:726854|Remove unused eventlogging_RUMSpeedIndex stream (T286700)]] synced to the testservers: mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug2001.codfw.wmnet, mwdebug1001.eqiad.wmnet

Mentioned in SAL (#wikimedia-operations) [2023-02-01T08:14:43Z] <ladsgroup@deploy1002> Finished scap: Backport for [[gerrit:726854|Remove unused eventlogging_RUMSpeedIndex stream (T286700)]] (duration: 10m 15s)

Change 726852 merged by Ottomata:

[operations/puppet@production] eventlogging: Remove obsoleted navtiming schemas

https://gerrit.wikimedia.org/r/726852

Change 887425 had a related patch set uploaded (by Krinkle; author: Krinkle):

[schemas/event/secondary@master] Remove elementtiming,firstinputtiming,layoutshift,resourcetiming,rumspeedindex

https://gerrit.wikimedia.org/r/887425

Change 887425 merged by jenkins-bot:

[schemas/event/secondary@master] Remove elementtiming,firstinputtiming,layoutshift,resourcetiming,rumspeedindex

https://gerrit.wikimedia.org/r/887425