Page MenuHomePhabricator
Create Task
Maniphest T287136

Hard-deprecate CentralIdLookup::factory
Closed, ResolvedPublic
Actions

Description

CentralIdLookup::factory() result is now a 'CentralIdLookup' service and is injectable
CentralIdLookupFactory is an injectable service that provides access to other factory methods for CentralIdLookup.

Deprecated factory methods in CentralIdLookup class need to be hard-deprecated

Codesearch deployed extensions

  • extensions / ReadingLists
  • extensions / Babel
  • extensions / ContentTranslation
  • extensions / Flow
  • extensions / OATHAuth
  • extensions / OAuth
  • extensions / CheckUser
  • extensions / FileImporter
  • extensions / GlobalBlocking
  • extensions / GlobalCssJs
  • extensions / GlobalPreferences
  • extensions / GlobalUserPage
  • extensions / MassMessage
  • extensions / WikimediaEditorTasks
  • skins / Vector

Details

SubjectRepoBranchLines +/-
Hard-deprecate CentralIdLookup::factory and ::factoryNonLocalmediawiki/coremaster+4 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Pchelolo created this task.Jul 22 2021, 2:19 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 22 2021, 2:19 AM
• Pchelolo moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Jul 26 2021, 1:31 PM
• Pchelolo reassigned this task from Vlad.shapik to tchin.Jul 29 2021, 6:12 PM
• Pchelolo added a subscriber: Vlad.shapik.
tchin updated the task description. (Show Details)Aug 12 2021, 1:27 PM
• Pchelolo added a comment.Aug 12 2021, 1:30 PM

While you're at it, can probably skim usages and see if you can loosen some typehints now that CentralIdLookup accepts UserIdentity.

tchin moved this task from UserStore pile to Doing on the Platform Team Workboards (MW Expedition) board.Aug 12 2021, 4:40 PM
tchin updated the task description. (Show Details)Aug 13 2021, 1:58 PM
Umherirrender closed subtask T288855: extensions / CheckUser - Replace deprecated CentralIdLookup::factory as Resolved.Aug 17 2021, 8:20 PM
Umherirrender closed subtask T288837: extensions / OAuth - Replace deprecated CentralIdLookup::factory as Resolved.
Umherirrender closed subtask T288836: extensions / OATHAuth - Replace deprecated CentralIdLookup::factory as Resolved.
Umherirrender closed subtask T288821: extensions / ContentTranslation - Replace deprecated CentralIdLookup::factory as Resolved.
tchin closed subtask T288859: extensions / FileImporter - Replace deprecated CentralIdLookup::factory as Resolved.Aug 18 2021, 1:09 PM
tchin updated the task description. (Show Details)Aug 18 2021, 1:25 PM
tchin closed subtask T288966: extensions / GlobalCssJs - Replace deprecated CentralIdLookup::factory as Resolved.Aug 24 2021, 3:05 PM
tchin closed subtask T288738: extensions / ReadingLists - Replace deprecated CentralIdLookup::factory as Resolved.
tchin closed subtask T288965: extensions / GlobalBlocking - Replace deprecated CentralIdLookup::factory as Resolved.
tchin updated the task description. (Show Details)Aug 24 2021, 4:05 PM
tchin closed subtask T289686: extensions / WikimediaEditorTasks - Replace deprecated CentralIdLookup::factory as Resolved.Aug 31 2021, 3:08 PM
tchin closed subtask T289713: skins / Vector - Replace deprecated CentralIdLookup::factory as Resolved.
tchin closed subtask T289684: extensions / GlobalUserPage - Replace deprecated CentralIdLookup::factory as Resolved.
tchin closed subtask T289683: extensions / GlobalPreferences - Replace deprecated CentralIdLookup::factory as Resolved.
tchin closed subtask T288746: extensions / Babel - Replace deprecated CentralIdLookup::factory as Resolved.Aug 31 2021, 3:10 PM
tchin closed subtask T289685: extensions / MassMessage - Replace deprecated CentralIdLookup::factory as Resolved.
tchin closed subtask T288822: extensions / Flow - Replace deprecated CentralIdLookup::factory as Resolved.
tchin updated the task description. (Show Details)
gerritbot added a comment.Sep 2 2021, 4:13 PM

Change 716412 had a related patch set uploaded (by TChin; author: TChin):

[mediawiki/core@master] Hard-deprecate CentralIdLookup::factory and ::factoryNonLocal

https://gerrit.wikimedia.org/r/716412

gerritbot added a project: Patch-For-Review.Sep 2 2021, 4:13 PM
gerritbot added a comment.Sep 2 2021, 7:44 PM

Change 716412 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate CentralIdLookup::factory and ::factoryNonLocal

https://gerrit.wikimedia.org/r/716412

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 2 2021, 8:00 PM
tchin moved this task from Doing to On the train on the Platform Team Workboards (MW Expedition) board.Sep 2 2021, 8:04 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 2 2021, 8:11 PM
tchin closed this task as Resolved.Sep 14 2021, 6:43 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL