Page MenuHomePhabricator
Create Task
Maniphest T287471

Validate and autocomplete database names in the database input field
Closed, ResolvedPublic
Actions

Description

There is confusion around the new DB input field, the UX could be improved by making it clearer what should go in the field and showing hints when typing.

  • Make the textarea an input field. Add a label before the input.
  • Add autocomplete for the DB names

Confusion example:

Related tasks

Other thoughts

Details

SubjectRepoBranchLines +/-
Add database autocompletionanalytics/quarry/webbuster+169 -2
Add database autocompletionanalytics/quarry/webbuster+160 -2
Add database autocompletionanalytics/quarry/webmaster+169 -2
Add database autocompletionanalytics/quarry/webmaster+160 -2
Customize query in gerrit

Related Objects

Event Timeline

• Jhernandez created this task.Jul 27 2021, 1:34 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 27 2021, 1:34 PM
• Jhernandez added a project: Quarry.Jul 27 2021, 1:34 PM
• nskaggs subscribed.Aug 2 2021, 8:32 PM

Consider an implementation that also allows for database selection and resolves T76466 also.

• nskaggs moved this task from Backlog to Planning on the Quarry board.Aug 2 2021, 8:45 PM
dcaro claimed this task.Aug 3 2021, 3:34 PM
dcaro moved this task from Planning to FY2021/2022-Q1 on the Quarry board.
dcaro edited projects, added Quarry (FY2021/2022-Q1); removed Quarry.
• nskaggs added a project: cloud-services-team (FY2021/2022-Q3).Aug 3 2021, 3:44 PM
dcaro triaged this task as Medium priority.Aug 5 2021, 11:18 AM
dcaro moved this task from Inbox to Doing on the cloud-services-team (Kanban) board.Aug 10 2021, 2:16 PM
dcaro edited projects, added cloud-services-team (Kanban); removed cloud-services-team (FY2021/2022-Q3).
gerritbot added a comment.Aug 11 2021, 11:39 AM

Change 711456 had a related patch set uploaded (by David Caro; author: David Caro):

[analytics/quarry/web@master] Add database autocompletion

https://gerrit.wikimedia.org/r/711456

gerritbot added a project: Patch-For-Review.Aug 11 2021, 11:39 AM
gerritbot added a comment.Aug 16 2021, 10:18 AM

Change 711456 merged by David Caro:

[analytics/quarry/web@master] Add database autocompletion

https://gerrit.wikimedia.org/r/711456

Stashbot added a comment.Aug 16 2021, 10:19 AM

Mentioned in SAL (#wikimedia-cloud) [2021-08-16T10:19:55Z] <dcaro> Deploying T287471 1/2 - creating DB index

Stashbot added a comment.Aug 16 2021, 10:21 AM

Mentioned in SAL (#wikimedia-cloud) [2021-08-16T10:21:22Z] <dcaro> Deploying T287471 2/2 - updating code on the web and worker servers

Stashbot added a comment.Aug 16 2021, 10:25 AM

Mentioned in SAL (#wikimedia-cloud) [2021-08-16T10:25:37Z] <dcaro> Reverting deploy of T287471 - saved queries fail to show the DB field, will open a task

gerritbot added a comment.Aug 16 2021, 10:50 AM

Change 713237 had a related patch set uploaded (by David Caro; author: David Caro):

[analytics/quarry/web@master] Add database autocompletion

https://gerrit.wikimedia.org/r/713237

Stashbot added a comment.Aug 23 2021, 9:57 AM

Mentioned in SAL (#wikimedia-cloud) [2021-08-23T09:57:52Z] <dcaro> Deploy https://gerrit.wikimedia.org/r/c/analytics/quarry/web/+/713237 on dev server (T287471)

gerritbot added a comment.Aug 23 2021, 10:07 AM

Change 713237 merged by jenkins-bot:

[analytics/quarry/web@master] Add database autocompletion

https://gerrit.wikimedia.org/r/713237

Stashbot added a comment.Aug 23 2021, 10:10 AM

Mentioned in SAL (#wikimedia-cloud) [2021-08-23T10:10:03Z] <dcaro> Deploy https://gerrit.wikimedia.org/r/c/analytics/quarry/web/+/713237 on prod server (T287471)

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2021, 10:10 AM
dcaro closed this task as Resolved.Aug 23 2021, 11:04 AM

The validation added is kinda lose, as the data for the available databases gets populated from the queries that have been already run but it can't differentiate between those that have a valid DB or not, there's some filtering out obviously wrong DB names, but that's all.

We might want to tackle the validation in another way in the future (and maybe replace the backend /api/dbs call with something more trustworthy). For now seems to be good enough.

gerritbot added a comment.Aug 24 2021, 2:44 PM

Change 714573 had a related patch set uploaded (by Michael DiPietro; author: David Caro):

[analytics/quarry/web@buster] Add database autocompletion

https://gerrit.wikimedia.org/r/714573

gerritbot added a project: Patch-For-Review.Aug 24 2021, 2:44 PM

Change 714577 had a related patch set uploaded (by Michael DiPietro; author: David Caro):

[analytics/quarry/web@buster] Add database autocompletion

https://gerrit.wikimedia.org/r/714577

gerritbot added a comment.Aug 24 2021, 3:18 PM

Change 714573 merged by jenkins-bot:

[analytics/quarry/web@buster] Add database autocompletion

https://gerrit.wikimedia.org/r/714573

gerritbot added a comment.Aug 24 2021, 3:22 PM

Change 714577 merged by jenkins-bot:

[analytics/quarry/web@buster] Add database autocompletion

https://gerrit.wikimedia.org/r/714577

Vahurzpu mentioned this in T289943: Quarry suggests invalid database names, and doesn't suggest some valid database names.Aug 29 2021, 3:27 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits