Page MenuHomePhabricator
Create Task
Maniphest T287988

PHP Warning: Class __PHP_Incomplete_Class has no unserializer
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   PHP Warning: Class __PHP_Incomplete_Class has no unserializer
exception.trace
from /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/objectcache/MediumSpecificBagOStuff.php(1174)
#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/objectcache/MediumSpecificBagOStuff.php(1174): unserialize(string)
#2 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/objectcache/RedisBagOStuff.php(106): MediumSpecificBagOStuff->unserialize(string)
#3 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/objectcache/MediumSpecificBagOStuff.php(124): RedisBagOStuff->doGet(string, integer)
#4 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/ChronologyProtector.php(484): MediumSpecificBagOStuff->get(string)
#5 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/ChronologyProtector.php(408): Wikimedia\Rdbms\ChronologyProtector->lazyStartup()
#6 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/ChronologyProtector.php(269): Wikimedia\Rdbms\ChronologyProtector->getStartupSessionPositions()
#7 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/lbfactory/LBFactory.php(654): Wikimedia\Rdbms\ChronologyProtector->applySessionReplicationPosition(Wikimedia\Rdbms\LoadBalancer)
#8 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1486): Wikimedia\Rdbms\LBFactory->Wikimedia\Rdbms\{closure}(Wikimedia\Rdbms\LoadBalancer)
#9 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/loadbalancer/LoadBalancer.php(558): Wikimedia\Rdbms\LoadBalancer->lazyLoadReplicationPositions()
#10 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/loadbalancer/LoadBalancer.php(510): Wikimedia\Rdbms\LoadBalancer->getReaderIndex(string, string)
#11 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/loadbalancer/LoadBalancer.php(962): Wikimedia\Rdbms\LoadBalancer->getConnectionIndex(integer, array, string)
#12 /srv/mediawiki/php-1.37.0-wmf.16/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1097): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string, integer)
#13 /srv/mediawiki/php-1.37.0-wmf.16/includes/user/ActorStore.php(680): Wikimedia\Rdbms\LoadBalancer->getConnectionRef(integer, array, string)
#14 /srv/mediawiki/php-1.37.0-wmf.16/includes/user/ActorStore.php(724): MediaWiki\User\ActorStore->getDBConnectionRefForQueryFlags(integer)
#15 /srv/mediawiki/php-1.37.0-wmf.16/includes/user/ActorStore.php(243): MediaWiki\User\ActorStore->newSelectQueryBuilderForQueryFlags(integer)
#16 /srv/mediawiki/php-1.37.0-wmf.16/includes/user/User.php(936): MediaWiki\User\ActorStore->getUserIdentityByName(string, integer)
#17 /srv/mediawiki/php-1.37.0-wmf.16/extensions/CentralAuth/includes/CentralAuthUser.php(2080): User::idFromName(string)
#18 /srv/mediawiki/php-1.37.0-wmf.16/extensions/CentralAuth/includes/CentralAuthUser.php(2138): CentralAuthUser->canAuthenticate()
#19 /srv/mediawiki/php-1.37.0-wmf.16/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php(194): CentralAuthUser->authenticateWithToken(string)
#20 /srv/mediawiki/php-1.37.0-wmf.16/includes/session/SessionManager.php(525): CentralAuthSessionProvider->provideSessionInfo(WebRequest)
#21 /srv/mediawiki/php-1.37.0-wmf.16/includes/session/SessionManager.php(248): MediaWiki\Session\SessionManager->getSessionInfoForRequest(WebRequest)
#22 /srv/mediawiki/php-1.37.0-wmf.16/includes/WebRequest.php(826): MediaWiki\Session\SessionManager->getSessionForRequest(WebRequest)
#23 /srv/mediawiki/php-1.37.0-wmf.16/includes/session/SessionManager.php(169): WebRequest->getSession()
#24 /srv/mediawiki/php-1.37.0-wmf.16/includes/Setup.php(740): MediaWiki\Session\SessionManager::getGlobalSession()
#25 /srv/mediawiki/php-1.37.0-wmf.16/includes/WebStart.php(87): require_once(string)
#26 /srv/mediawiki/php-1.37.0-wmf.16/api.php(43): require(string)
#27 /srv/mediawiki/w/api.php(3): require(string)
#28 {main}
Impact

1700+ similar error messages within a 10 minutes of 1.37.0-wmf.17 promotion to group0.

Notes

There are many traces and similar manifesting errors to choose from. I've arbitrarily selected this one. Note that errors occurred in both existing wmf.16 wikis and the new wmf.17 version upon group0 promotion.

Details

Request URL
https://en.wikipedia.org/w/api.php
SubjectRepoBranchLines +/-
Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPosmediawiki/corewmf/1.37.0-wmf.16+12 -0
Revert "Rename DB primary position interfaces to DBPrimaryPos and MySQLPrimaryPos"mediawiki/coremaster+167 -193
Revert "Revert "Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos""mediawiki/corewmf/1.37.0-wmf.16+12 -0
Revert "Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos"mediawiki/corewmf/1.37.0-wmf.16+0 -12
Add MySQLPrimaryPos as an alias to MySQLMasterPosmediawiki/corewmf/1.37.0-wmf.17+0 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

dduvall triaged this task as Unbreak Now! priority.Aug 3 2021, 7:37 PM
dduvall created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2021, 7:37 PM
dduvall added a parent task: T281158: 1.37.0-wmf.17 deployment blockers.Aug 3 2021, 7:37 PM

IRC discussion suggests https://gerrit.wikimedia.org/r/c/mediawiki/core/+/691272 may be the culprit. cc T282894: Rename …master methods in ILoadBalancer to …primary

gerritbot added a comment.Aug 3 2021, 7:39 PM

Change 709815 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@master] Revert \"Rename DB primary position interfaces to DBPrimaryPos and MySQLPrimaryPos\"

https://gerrit.wikimedia.org/r/709815

gerritbot added a project: Patch-For-Review.Aug 3 2021, 7:39 PM
dduvall added a project: Performance-Team.Aug 3 2021, 7:39 PM
taavi subscribed.Aug 3 2021, 7:39 PM
Zabe subscribed.Aug 3 2021, 7:40 PM
gerritbot added a comment.Aug 3 2021, 7:41 PM

Change 709788 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.37.0-wmf.17] Add MySQLPrimaryPos as an alias to MySQLMasterPos

https://gerrit.wikimedia.org/r/709788

gerritbot added a comment.Aug 3 2021, 7:42 PM

Change 709788 abandoned by Urbanecm:

[mediawiki/core@wmf/1.37.0-wmf.17] Add MySQLPrimaryPos as an alias to MySQLMasterPos

Reason:

wrong branch

https://gerrit.wikimedia.org/r/709788

gerritbot added a comment.Aug 3 2021, 7:42 PM

Change 709789 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.37.0-wmf.16] Add MySQLPrimaryPos as an alias to MySQLMasterPos

https://gerrit.wikimedia.org/r/709789

taavi added a project: MediaWiki-libs-Rdbms.Aug 3 2021, 7:42 PM
Krinkle removed a project: Platform Engineering.Aug 3 2021, 7:47 PM
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
Urbanecm subscribed.Aug 3 2021, 7:55 PM
Zabe moved this task from Untriaged to July 2021 on the Wikimedia-production-error board.Aug 3 2021, 8:28 PM
Zabe moved this task from July 2021 to Aug 2021 on the Wikimedia-production-error board.
gerritbot added a comment.Aug 3 2021, 8:30 PM

Change 709789 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.16] Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos

https://gerrit.wikimedia.org/r/709789

Stashbot added a comment.Aug 3 2021, 8:39 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T20:39:05Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/autoload.php: rMW2d4ea752ec6f: Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos (T287988; 1/3) (duration: 01m 08s)

Stashbot added a comment.Aug 3 2021, 8:40 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T20:40:33Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/includes/libs/rdbms/database/position/DBMasterPos.php: rMW2d4ea752ec6f: Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos (T287988; 2/3) (duration: 01m 07s)

Stashbot added a comment.Aug 3 2021, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T20:41:48Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/includes/libs/rdbms/database/position/DBMasterPos.php: REVERT: rMW2d4ea752ec6f: Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos (T287988; 2/3) (duration: 00m 37s)

Stashbot added a comment.Aug 3 2021, 8:44 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T20:44:21Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/autoload.php: REVERT: rMW2d4ea752ec6f: Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos (T287988; 1/3) (duration: 00m 37s)

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.16; 2021-07-26).Aug 3 2021, 9:00 PM
gerritbot added a comment.Aug 3 2021, 9:06 PM

Change 709790 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.37.0-wmf.16] Revert \"Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos\"

https://gerrit.wikimedia.org/r/709790

gerritbot added a comment.Aug 3 2021, 9:06 PM

Change 709790 merged by Urbanecm:

[mediawiki/core@wmf/1.37.0-wmf.16] Revert \"Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos\"

https://gerrit.wikimedia.org/r/709790

gerritbot added a comment.Aug 3 2021, 9:52 PM

Change 709791 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/core@wmf/1.37.0-wmf.16] Revert \"Revert \"Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos\"\"

https://gerrit.wikimedia.org/r/709791

gerritbot added a comment.Aug 3 2021, 10:12 PM

Change 709791 merged by jenkins-bot:

[mediawiki/core@wmf/1.37.0-wmf.16] Revert \"Revert \"Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos\"\"

https://gerrit.wikimedia.org/r/709791

Stashbot added a comment.Aug 3 2021, 10:15 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T22:15:52Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/includes/libs/rdbms/database/position/DBMasterPos.php: rMW7d286dc0feae: Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos (T287988; 1/3) (duration: 01m 07s)

Stashbot added a comment.Aug 3 2021, 10:18 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T22:18:20Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/includes/libs/rdbms/database/position/MySQLMasterPos.php: rMW7d286dc0feae: Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos (T287988; 2/3) (duration: 01m 07s)

Stashbot added a comment.Aug 3 2021, 10:20 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T22:20:01Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.16/autoload.php: rMW7d286dc0feae: Add (MySQL/DB)PrimaryPos as an alias to (MySQL/DB)MasterPos (T287988; 3/3) (duration: 01m 07s)

Stashbot mentioned this in T281158: 1.37.0-wmf.17 deployment blockers.Aug 3 2021, 10:37 PM

Mentioned in SAL (#wikimedia-operations) [2021-08-03T22:37:16Z] <dduvall> re-rolled 1.37.0-wmf.17 to group0 following rollback and subsequent fixes for T287988 (T281158)

dduvall closed this task as Resolved.Aug 3 2021, 10:39 PM
dduvall claimed this task.

I'm no longer seeing this error following the deployment of the future compatible fix and group0 promotion. Thanks, all!

Krinkle subscribed.Aug 3 2021, 10:42 PM

Macro opcache-was-here:

Krinkle added a parent task: T245183: PHP7 corruption reports in 2020-2022 (Call on wrong object, etc.).Aug 3 2021, 10:43 PM
gerritbot added a comment.Aug 3 2021, 10:43 PM

Change 709815 abandoned by Legoktm:

[mediawiki/core@master] Revert \"Rename DB primary position interfaces to DBPrimaryPos and MySQLPrimaryPos\"

Reason:

No longer needed, fixed by hack in wmf.16

https://gerrit.wikimedia.org/r/709815

Maintenance_bot removed a project: Patch-For-Review.Aug 3 2021, 11:10 PM
Urbanecm claimed this task.Aug 4 2021, 4:48 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptAug 4 2021, 4:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL