Page MenuHomePhabricator
Create Task
Maniphest T288597

Re-enable editing of local properties via the entity page when federated properties are enabled
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As a Wikibase editor, I want to be able to continue to maintain and edit my local ontology after enabling Federated Properties.

In Federated Properties v1, we disabled the editing of local properties in the Wikibase because no local properties were possible. We need to re-enable the editing of local properties while using Federated Properties v2.

Currently it fails on the entity page:

image.png (245×979 px, 21 KB)

BDD Scenario: On local property page in a Wikibase with Federated Properties enabled
GIVEN I am editing the local property (adding a statement, editing a statement, editing label/description/aliases)
WHEN I save my changes
THEN My changes are successfully saved
AND My changes are visible when the page (see: T285293)

We should also double check how well editing local properties using Special Pages (e.g. SetLabel) works.

Note:
This ticket will be simpler to verify after the completion of T285293.

Details

SubjectRepoBranchLines +/-
FP: change message shown when attempting to edit fed propsmediawiki/extensions/Wikibasemaster+13 -13
FP: re-enable editing local props when FP is enabledmediawiki/extensions/Wikibasemaster+286 -44
Customize query in gerrit

Related Objects

Event Timeline

• Samantha_Alipio_WMDE created this task.Aug 11 2021, 8:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 11 2021, 8:16 AM
• Samantha_Alipio_WMDE updated the task description. (Show Details)Aug 11 2021, 8:22 AM
• Samantha_Alipio_WMDE moved this task from Backlog to Ready for story writing on the Wikibase - Federated Properties board.Aug 11 2021, 8:38 AM
• Samantha_Alipio_WMDE updated the task description. (Show Details)Aug 11 2021, 9:27 AM
Tarrow updated the task description. (Show Details)Aug 11 2021, 9:28 AM
Tarrow updated the task description. (Show Details)
Tarrow updated the task description. (Show Details)
• Samantha_Alipio_WMDE moved this task from Ready for story writing to Ready to estimate on the Wikibase - Federated Properties board.Aug 11 2021, 9:29 AM
• Samantha_Alipio_WMDE renamed this task from Re-enable editing of local properties when federated properties are enabled to Re-enable editing of local properties via the entity page when federated properties are enabled.Aug 11 2021, 12:42 PM
• Samantha_Alipio_WMDE set the point value for this task to 5.
• Samantha_Alipio_WMDE moved this task from Ready to estimate to Ready for Breakdown on the Wikibase - Federated Properties board.
• Samantha_Alipio_WMDE triaged this task as High priority.Aug 18 2021, 9:30 AM
• Samantha_Alipio_WMDE updated the task description. (Show Details)Aug 18 2021, 9:35 AM
• Samantha_Alipio_WMDE moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.
• Samantha_Alipio_WMDE moved this task from Prioritized backlog (aka Ready to pick up) to Federation v2 - Sprint 5 on the Wikibase - Federated Properties board.Aug 18 2021, 9:37 AM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 5); removed Wikibase - Federated Properties.
• Samantha_Alipio_WMDE lowered the priority of this task from High to Medium.Aug 18 2021, 9:58 AM
• Samantha_Alipio_WMDE edited projects, added Wikibase - Federated Properties; removed Wikibase - Federated Properties (Federation v2 - Sprint 5).
• Samantha_Alipio_WMDE moved this task from Backlog to Ready to estimate on the Wikibase - Federated Properties board.Aug 18 2021, 10:03 AM
• Samantha_Alipio_WMDE moved this task from Ready to estimate to Ready for Breakdown on the Wikibase - Federated Properties board.
• Samantha_Alipio_WMDE raised the priority of this task from Medium to High.Sep 1 2021, 9:38 AM
Jakob_WMDE subscribed.Sep 1 2021, 10:08 AM

From task breakdown: Doesn't need breakdown.

This will likely involve

  • removing a federatedPropertiesEnabled? guard from the involved API endpoints
  • writing a new test checking that the API endpoint still fails when passed a Federated Property ID
  • potentially removing an existing test that checks that it always fails with fed props enabled
Jakob_WMDE moved this task from Ready for Breakdown to Federation v2 - Sprint 6 on the Wikibase - Federated Properties board.Sep 1 2021, 2:50 PM
Jakob_WMDE edited projects, added Wikibase - Federated Properties (Federation v2 - Sprint 6); removed Wikibase - Federated Properties.
Jakob_WMDE claimed this task.Sep 2 2021, 3:28 PM
Jakob_WMDE moved this task from To do to Doing on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.
gerritbot added a comment.Sep 3 2021, 1:45 PM

Change 717421 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: re-enable editing local props when FP is enabled

https://gerrit.wikimedia.org/r/717421

gerritbot added a project: Patch-For-Review.Sep 3 2021, 1:45 PM
Jakob_WMDE added a comment.Sep 6 2021, 8:53 AM

The existing guards in the APIs all respond with wikibase-federated-properties-local-property-api-error-message which says "You can not interact with properties using this API while federated properties is enabled" which no longer makes sense.

@Samantha_Alipio_WMDE what error message should we show in case someone tries to edit a Feddy Prop via an API? Something like "You cannot interact with Federated Properties using this API"?

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 7 2021, 11:03 AM
gerritbot added a comment.Sep 7 2021, 2:48 PM

Change 719277 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: change message shown when attempting to edit fed props

https://gerrit.wikimedia.org/r/719277

gerritbot added a comment.Sep 8 2021, 10:23 AM

Change 717421 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: re-enable editing local props when FP is enabled

https://gerrit.wikimedia.org/r/717421

Tarrow moved this task from Peer Review to Product Verification on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 8 2021, 10:45 AM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 8 2021, 11:00 AM
gerritbot added a comment.Sep 8 2021, 11:08 AM

Change 719277 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: change message shown when attempting to edit fed props

https://gerrit.wikimedia.org/r/719277

Maintenance_bot removed a project: Patch-For-Review.Sep 8 2021, 11:10 AM
Jakob_WMDE added a comment.Sep 8 2021, 1:24 PM

https://wikidata-federated-properties.wmflabs.org/wiki/Property:P1 <- can now be edited :)

• Samantha_Alipio_WMDE moved this task from Product Verification to Done on the Wikibase - Federated Properties (Federation v2 - Sprint 6) board.Sep 13 2021, 11:05 AM

Happily verified.

Addshore closed this task as Resolved.Jan 17 2022, 8:13 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits