Page MenuHomePhabricator

Community configuration should not save the edit as unpatrolled
Closed, ResolvedPublic

Description

Currently, community configuration does not check if the editing user has autopatrol right, and thus flags the edit for manual patrolling. Something similar happens for most of other editing Growth features (like "ask your mentor"), but since they're targeted at newcomers, it's less visible.

With community configuration, virtually everyone who has access to it also has autopatrol

This should be probably fixed within the config writer class.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 713069 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigWriter: Fix `autopatrol` right name

https://gerrit.wikimedia.org/r/713069

Turns out the code was already supposed to check for that, it just happened to use incorrect right name. Patch submitted.

Change 713069 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] WikiPageConfigWriter: Fix `autopatrol` right name

https://gerrit.wikimedia.org/r/713069

Change 714676 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.19] WikiPageConfigWriter: Fix `autopatrol` right name

https://gerrit.wikimedia.org/r/714676

Change 714676 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.37.0-wmf.19] WikiPageConfigWriter: Fix `autopatrol` right name

https://gerrit.wikimedia.org/r/714676

Mentioned in SAL (#wikimedia-operations) [2021-08-25T15:02:39Z] <urbanecm@deploy1002> Synchronized php-1.37.0-wmf.19/extensions/GrowthExperiments/includes/Config/WikiPageConfigWriter.php: 0b9ca1e11c1f0397847d4cfc7bc86220b6ebe9f6: WikiPageConfigWriter: Fix autopatrol right name (T288886) (duration: 01m 04s)