Categorytrees on RTL categories with LTR user interface language have a wrong direction
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Fomafix
	Aug 15 2021, 2:05 PM

Description

https://he.wikipedia.org/wiki/%D7%A7%D7%98%D7%92%D7%95%D7%A8%D7%99%D7%94:%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94_-_%D7%AA%D7%9E%D7%95%D7%A0%D7%95%D7%AA_%D7%9C%D7%A4%D7%99_%D7%A8%D7%99%D7%A9%D7%99%D7%95%D7%9F?uselang=he with RTL user interface language shows currently correct

https://he.wikipedia.org/wiki/%D7%A7%D7%98%D7%92%D7%95%D7%A8%D7%99%D7%94:%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94_-_%D7%AA%D7%9E%D7%95%D7%A0%D7%95%D7%AA_%D7%9C%D7%A4%D7%99_%D7%A8%D7%99%D7%A9%D7%99%D7%95%D7%9F?uselang=en with LTR user interface language shows currently

Expected result is:

The bullets must also flipped RTL bullets.

Test case

The wikitext

Normal
<categorytree mode=all>!Hauptkategorie</categorytree>

<div class="mw-content-ltr">LTR
<categorytree mode=all>!Hauptkategorie</categorytree>
</div>

<div class="mw-content-rtl">RTL
<categorytree mode=all>!Hauptkategorie</categorytree>
</div>

on a RTL page content language (ar) looks currently
with a LTR user interface language (en)

and with a RTL user interface language (en-rtl)

Expected result is
with a LTR user interface language (en)

and with a RTL user interface language (en-rtl)

Details

Subject	Repo	Branch	Lines +/-
Step 2 of move bullets from HTML to CSS	mediawiki/extensions/CategoryTree	master	+13 -17
[CategoryTree] Drop ignore/optional of categorytree-expand/collapse-bullet, dropped	translatewiki	master	+1 -2
Move bullets from HTML to CSS	mediawiki/extensions/CategoryTree	master	+40 -24
Use text direction based on the context	mediawiki/extensions/CategoryTree	master	+34 -4

Customize query in gerrit

Related Objects

Mentioned In: rGTWN1723e9846281: [CategoryTree] Drop ignore/optional of categorytree-expand/collapse-bullet…

Event Timeline

Fomafix created this task.Aug 15 2021, 2:05 PM

Restricted Application added a project: I18n. · View Herald TranscriptAug 15 2021, 2:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Fomafix claimed this task.Aug 15 2021, 2:05 PM

Change 488975 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/CategoryTree@master] Use text direction based on the context

https://gerrit.wikimedia.org/r/488975

Change 488339 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/CategoryTree@master] Move bullets from HTML to CSS

https://gerrit.wikimedia.org/r/488339

Change 488582 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/CategoryTree@master] Step 2 of move bullets from HTML to CSS

https://gerrit.wikimedia.org/r/488582

eranroz subscribed.Aug 15 2021, 2:16 PM

Fomafix updated the task description. (Show Details)Aug 17 2021, 9:54 AM

Fomafix renamed this task from An embedded categorytree should use the language direction of the content to An embedded categorytree should use the language direction of the context.Aug 17 2021, 9:58 AM

Fomafix renamed this task from An embedded categorytree should use the language direction of the context to Categorytrees on RTL categories with LTR user interface language have a wrong direction.Aug 20 2021, 8:34 AM

Fomafix updated the task description. (Show Details)

Change 488975 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Use text direction based on the context

https://gerrit.wikimedia.org/r/488975

Change 714431 had a related patch set uploaded (by Jforrester; author: Jforrester):

[translatewiki@master] [CategoryTree] Drop ignore/optional of categorytree-expand/collapse-bullet, dropped

https://gerrit.wikimedia.org/r/714431

This should be done with this week's train (except for cached HTML).

Change 488339 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Move bullets from HTML to CSS

https://gerrit.wikimedia.org/r/488339

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 24 2021, 12:00 AM

Change 714431 merged by jenkins-bot:

[translatewiki@master] [CategoryTree] Drop ignore/optional of categorytree-expand/collapse-bullet, dropped

https://gerrit.wikimedia.org/r/714431

Jdforrester-WMF mentioned this in rGTWN1723e9846281: [CategoryTree] Drop ignore/optional of categorytree-expand/collapse-bullet….Aug 24 2021, 6:59 AM

The UI of the category tree in mixed directions is fixed.

Change 488582 merged by jenkins-bot: