Page MenuHomePhabricator

Categorytrees on RTL categories with LTR user interface language have a wrong direction
Closed, ResolvedPublicBUG REPORT

Description

https://he.wikipedia.org/wiki/%D7%A7%D7%98%D7%92%D7%95%D7%A8%D7%99%D7%94:%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94_-_%D7%AA%D7%9E%D7%95%D7%A0%D7%95%D7%AA_%D7%9C%D7%A4%D7%99_%D7%A8%D7%99%D7%A9%D7%99%D7%95%D7%9F?uselang=he with RTL user interface language shows currently correct

grafik.png (575×935 px, 54 KB)

https://he.wikipedia.org/wiki/%D7%A7%D7%98%D7%92%D7%95%D7%A8%D7%99%D7%94:%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94_-_%D7%AA%D7%9E%D7%95%D7%A0%D7%95%D7%AA_%D7%9C%D7%A4%D7%99_%D7%A8%D7%99%D7%A9%D7%99%D7%95%D7%9F?uselang=en with LTR user interface language shows currently

grafik.png (592×930 px, 57 KB)

Expected result is:

grafik.png (577×932 px, 56 KB)

The bullets must also flipped RTL bullets.

Test case

The wikitext

Normal
<categorytree mode=all>!Hauptkategorie</categorytree>

<div class="mw-content-ltr">LTR
<categorytree mode=all>!Hauptkategorie</categorytree>
</div>

<div class="mw-content-rtl">RTL
<categorytree mode=all>!Hauptkategorie</categorytree>
</div>

on a RTL page content language (ar) looks currently
with a LTR user interface language (en)

grafik.png (499×756 px, 20 KB)

and with a RTL user interface language (en-rtl)
grafik.png (516×754 px, 19 KB)

Expected result is
with a LTR user interface language (en)

grafik.png (511×753 px, 20 KB)

and with a RTL user interface language (en-rtl)
grafik.png (514×755 px, 19 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 488975 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/CategoryTree@master] Use text direction based on the context

https://gerrit.wikimedia.org/r/488975

Change 488339 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/CategoryTree@master] Move bullets from HTML to CSS

https://gerrit.wikimedia.org/r/488339

Change 488582 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/CategoryTree@master] Step 2 of move bullets from HTML to CSS

https://gerrit.wikimedia.org/r/488582

Fomafix renamed this task from An embedded categorytree should use the language direction of the content to An embedded categorytree should use the language direction of the context.Aug 17 2021, 9:58 AM
Fomafix renamed this task from An embedded categorytree should use the language direction of the context to Categorytrees on RTL categories with LTR user interface language have a wrong direction.Aug 20 2021, 8:34 AM
Fomafix updated the task description. (Show Details)

Change 488975 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Use text direction based on the context

https://gerrit.wikimedia.org/r/488975

Change 714431 had a related patch set uploaded (by Jforrester; author: Jforrester):

[translatewiki@master] [CategoryTree] Drop ignore/optional of categorytree-expand/collapse-bullet, dropped

https://gerrit.wikimedia.org/r/714431

This should be done with this week's train (except for cached HTML).

Change 488339 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Move bullets from HTML to CSS

https://gerrit.wikimedia.org/r/488339

Change 714431 merged by jenkins-bot:

[translatewiki@master] [CategoryTree] Drop ignore/optional of categorytree-expand/collapse-bullet, dropped

https://gerrit.wikimedia.org/r/714431

The UI of the category tree in mixed directions is fixed.

Change 488582 merged by jenkins-bot:

[mediawiki/extensions/CategoryTree@master] Step 2 of move bullets from HTML to CSS

https://gerrit.wikimedia.org/r/488582