Update CSSJanus to version 2.0.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Fomafix
	Aug 16 2021, 11:30 AM

Description

CSSJanus version 1.3.0 has a flipping bug.

Input:

/*@noflip*/ .selector-ltr[ data-foo='bar' ]:empty { border-left: 10px none; border-right: 0 none; }

Expected output:

.selector-ltr[ data-foo='bar' ]:empty { border-left: 10px none; border-right: 0 none; }

Actual output:

.selector-ltr[ data-foo='bar' ]:empty { border-left: 10px none; border-left: 0 none; }

CSSJanus version 2.0.0 fixes this bug.

Details

Subject	Repo	Branch	Lines +/-
Remove @noflip workaround for T288943	mediawiki/extensions/CategoryTree	master	+1 -5
Follow-up 6157bdaef: Add RELEASE-NOTES for CSSJanus update	mediawiki/core	master	+1 -0
CSSJanus: Update from version 1.3.0 to version 2.0.0	mediawiki/core	master	+7 -1
Update cssjanus from 1.3.0 to 2.0.0	mediawiki/vendor	master	+113 -228

Customize query in gerrit

Event Timeline

Fomafix created this task.Aug 16 2021, 11:30 AM

Restricted Application added projects: I18n, Performance-Team. · View Herald TranscriptAug 16 2021, 11:30 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 713253 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/core@master] CSSJanus: Update from version 1.3.0 to version 2.0.0

https://gerrit.wikimedia.org/r/713253

gerritbot added a project: Patch-For-Review.Aug 16 2021, 11:32 AM

Change 713254 had a related patch set uploaded (by Fomafix; author: Fomafix):

[mediawiki/extensions/CategoryTree@master] Remove @noflip workaround for T288943

https://gerrit.wikimedia.org/r/713254

• dpifke moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Aug 16 2021, 6:34 PM

Sounds good to me. Looks like Bartosz is reviewing already, but if not, ping me on Gerrit for review.

I had forgotten to update MediaWiki with CSSJanus 2.0 because I was going to port CSSJanus 2.1 at the same time, but since that's been a TODO for a few weeks now, feel free to go ahead.

Change 713305 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/vendor@master] Update cssjanus from 1.3.0 to 2.0.0

https://gerrit.wikimedia.org/r/713305

Change 713305 merged by jenkins-bot:

[mediawiki/vendor@master] Update cssjanus from 1.3.0 to 2.0.0

https://gerrit.wikimedia.org/r/713305

Change 713253 merged by jenkins-bot:

[mediawiki/core@master] CSSJanus: Update from version 1.3.0 to version 2.0.0

https://gerrit.wikimedia.org/r/713253

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 16 2021, 9:00 PM

matmarex closed this task as Resolved.Aug 16 2021, 9:02 PM

matmarex subscribed.