Page MenuHomePhabricator

Replace hard coded "https://maps.wikimedia.org" by $wgKartographerMapServer in specialMap.less
Closed, ResolvedPublic

Description

The configuration variable wgKartographerMapServer already exist and is used in PHP and in JavaScript but not yet in LESS. In specialMap.less ( https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Kartographer/+/refs/heads/master/styles/specialMap.less ) there is currently hard coded:

background-image: url(https://maps.wikimedia.org/osm-intl/0/0/0.png);

Here the https://maps.wikimedia.org should be replaced by the configuration variable wgKartographerMapServer.

Event Timeline

Change 738279 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/Kartographer@master] Remove hardcoded maps.wikimedia.org url in styles

https://gerrit.wikimedia.org/r/738279

Change 738279 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Remove hardcoded maps.wikimedia.org url in styles

https://gerrit.wikimedia.org/r/738279

Fomafix assigned this task to TheDJ.
Fomafix removed a project: Patch-For-Review.