Page MenuHomePhabricator

Rethink FederatedPropertiesParserOutputGenerator
Closed, ResolvedPublic

Description

Currently this class does multiple things:

  • prefetches federated property data
  • turns on some OOUI modules
  • handles feddy props errors

It's also odd because it's called FederatedProperties* and we still have to filter them out of all propertyIds.
It calls the statsd parser output generator which calls the full one, this means that prefetching feddy props is not taken into account when timing the parser output generation.

Finally this thing doesn't actually generate FederatedPropertiesParserOutput. If anything it's a few different wrapping layers (e.g. prefetching, OOUI enabling etc.). These layers could be split up and given more appropriate names.

Event Timeline

Change 715921 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: improve FPEPOG comments

https://gerrit.wikimedia.org/r/715921

Change 715921 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: improve FPEPOG comments

https://gerrit.wikimedia.org/r/715921

Change 720715 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: refactor FederatedPropertiesEntityParserOutputGenerator

https://gerrit.wikimedia.org/r/720715

Change 720722 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] FP: remove unnecessary prefetch optimization

https://gerrit.wikimedia.org/r/720722

Change 720715 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: refactor FederatedPropertiesEntityParserOutputGenerator

https://gerrit.wikimedia.org/r/720715

Change 720722 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] FP: remove unnecessary prefetch optimization

https://gerrit.wikimedia.org/r/720722