Page MenuHomePhabricator

"Not empty" composition does not seem to work
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Create a function Negation with an implementation composition if x then false else true
  • Created a function "Not empty"
  • Create an implementation, composing Negation and Empty
  • Run that on an empty list, it correctly returns false
  • Run that on a non-empty list

I will update this bug with links to notwikilambda having this implemented once T289682 is resolved

What happens?:
I get an error saying Z8K4 did not contain a valid implementation

What should have happened instead?:
true

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

I think I’ve set up your reproduction steps at https://notwikilambda.toolforge.org/wiki/Z10062, though evaluation still seems to be broken on Not Wikilambda.

Fixed evaluation. Now I can’t reproduce the bug. Calling Z10062 on an empty list returns false, calling it on a one-element list (element “true”) returns true.

Oh, that's good! I will reinstall my system and see if I can reproduce it there, but I am glad it is not happening on Notwikilambda.

Change 751970 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/extensions/WikiLambda@master] Add \"not empty\" function (implemented as a composition) as an API example.

https://gerrit.wikimedia.org/r/751970

Jdforrester-WMF reassigned this task from DVrandecic to cmassaro.
Jdforrester-WMF subscribed.

With the new example API call this is definitely fixed.

Change 751970 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add \"not empty\" function (implemented as a composition) as an API example.

https://gerrit.wikimedia.org/r/751970