Page MenuHomePhabricator
Create Task
Maniphest T290000

SecurePoll: Tally page display issues when numbers are above 1000
Closed, ResolvedPublicBUG REPORT
Actions

Description

What is the problem?

If an election has numbers over 1000, it can lead to incorrect output in the tally page like: "1": 2,000 - 1 = 1,666.666668 (keep factor: 0.833333)

It also leads to errors in the logs like:

2021-08-26 12:48:55 [YSeNt-rwfjiz1jlhHBIJCAAAABQ] deployment-mediawiki11 votewiki 1.37.0-alpha error ERROR: [YSeNt-rwfjiz1jlhHBIJCAAAABQ] /wiki/Special:SecurePoll/tally/1954   PHP Notice: A non well formed numeric value encountered {"exception_url":"/wiki/Special:SecurePoll/tally/1954","reqId":"YSeNt-rwfjiz1jlhHBIJCAAAABQ","caught_by":"mwe_handler"} 
[Exception ErrorException] (/srv/mediawiki/php-master/extensions/SecurePoll/includes/Talliers/STVTallier.php:294) PHP Notice: A non well formed numeric value encountered
  #0 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Talliers/STVTallier.php(294): MWExceptionHandler::handleError(integer, string, string, integer, array)
  #1 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Talliers/ElectionTallier.php(185): MediaWiki\Extensions\SecurePoll\Talliers\STVTallier->getHtmlResult()
  #2 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Pages/TallyPage.php(208): MediaWiki\Extensions\SecurePoll\Talliers\ElectionTallier->getHtmlResult()
  #3 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Pages/TallyPage.php(92): MediaWiki\Extensions\SecurePoll\Pages\TallyPage->showTallyResult()
  #4 /srv/mediawiki/php-master/extensions/SecurePoll/includes/SpecialSecurePoll.php(70): MediaWiki\Extensions\SecurePoll\Pages\TallyPage->execute(array)
  #5 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(646): MediaWiki\Extensions\SecurePoll\SpecialSecurePoll->execute(string)
  #6 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1366): SpecialPage->run(string)
  #7 /srv/mediawiki/php-master/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
  #8 /srv/mediawiki/php-master/includes/MediaWiki.php(925): MediaWiki->performRequest()
  #9 /srv/mediawiki/php-master/includes/MediaWiki.php(559): MediaWiki->main()
  #10 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
  #11 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
  #12 /srv/mediawiki/w/index.php(3): require(string)
  #13 {main}
2021-08-26 12:48:55 [YSeNt-rwfjiz1jlhHBIJCAAAABQ] deployment-mediawiki11 votewiki 1.37.0-alpha error ERROR: [YSeNt-rwfjiz1jlhHBIJCAAAABQ] /wiki/Special:SecurePoll/tally/1954   PHP Notice: A non well formed numeric value encountered {"exception_url":"/wiki/Special:SecurePoll/tally/1954","reqId":"YSeNt-rwfjiz1jlhHBIJCAAAABQ","caught_by":"mwe_handler"} 
[Exception ErrorException] (/srv/mediawiki/php-master/extensions/SecurePoll/includes/Talliers/STVTallier.php:317) PHP Notice: A non well formed numeric value encountered
  #0 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Talliers/STVTallier.php(317): MWExceptionHandler::handleError(integer, string, string, integer, array)
  #1 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Talliers/ElectionTallier.php(185): MediaWiki\Extensions\SecurePoll\Talliers\STVTallier->getHtmlResult()
  #2 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Pages/TallyPage.php(208): MediaWiki\Extensions\SecurePoll\Talliers\ElectionTallier->getHtmlResult()
  #3 /srv/mediawiki/php-master/extensions/SecurePoll/includes/Pages/TallyPage.php(92): MediaWiki\Extensions\SecurePoll\Pages\TallyPage->showTallyResult()
  #4 /srv/mediawiki/php-master/extensions/SecurePoll/includes/SpecialSecurePoll.php(70): MediaWiki\Extensions\SecurePoll\Pages\TallyPage->execute(array)
  #5 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(646): MediaWiki\Extensions\SecurePoll\SpecialSecurePoll->execute(string)
  #6 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1366): SpecialPage->run(string)
  #7 /srv/mediawiki/php-master/includes/MediaWiki.php(314): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
  #8 /srv/mediawiki/php-master/includes/MediaWiki.php(925): MediaWiki->performRequest()
  #9 /srv/mediawiki/php-master/includes/MediaWiki.php(559): MediaWiki->main()
  #10 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
  #11 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
  #12 /srv/mediawiki/w/index.php(3): require(string)
  #13 {main}

And also:

2021-08-26 12:48:56 [YSeNt-rwfjiz1jlhHBIJCAAAABQ] deployment-mediawiki11 votewiki 1.37.0-alpha formatnum WARNING: Language::formatNum with non-numeric string {"number":"1,666.666668"}
2021-08-26 12:48:56 [YSeNt-rwfjiz1jlhHBIJCAAAABQ] deployment-mediawiki11 votewiki 1.37.0-alpha formatnum WARNING: Language::formatNum with non-numeric string {"number":"1,555.555557"} 
2021-08-26 12:48:56 [YSeNt-rwfjiz1jlhHBIJCAAAABQ] deployment-mediawiki11 votewiki 1.37.0-alpha formatnum WARNING: Language::formatNum with non-numeric string {"number":"1,185.185187"}

Found while testing T288740.

Steps to reproduce problem

blt file to reproduce errors above.

Examples on beta:

Environment

Wiki(s): SecurePoll 3.0.0 (1c3236a) 06:20, 30 August 2021

Details

SubjectRepoBranchLines +/-
Fix display issues when numbers are above 1000 or smallmediawiki/extensions/SecurePollwmf/1.37.0-wmf.21+52 -24
Fix display issues when numbers are above 1000 or smallmediawiki/extensions/SecurePollmaster+52 -24
Customize query in gerrit

Related Objects

Event Timeline

dom_walden created this task.Aug 30 2021, 12:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 30 2021, 12:52 PM
dom_walden mentioned this in T288740: SecurePoll: Inconsistencies in how we calculate and display small numbers.Aug 30 2021, 12:53 PM
ARamirez_WMF moved this task from Untriaged to The Letter Song on the Anti-Harassment board.Aug 30 2021, 6:07 PM
ARamirez_WMF edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.
• TThoabala claimed this task.Aug 30 2021, 8:41 PM
• IN subscribed.Aug 31 2021, 5:19 AM

Congratulations on creating your 290,000th task.

dom_walden added a comment.Aug 31 2021, 11:04 AM

This does not affect the way results appear when they are written to the database or dump file.

Here is an example of how it looks when you extract the results from the dump file and pretty print them: https://www.mediawiki.org/wiki/Anti-Harassment_Tools/SecurePoll_Improvements/Test_Results/5_2_5000_956342267/dump

Niharika subscribed.Aug 31 2021, 5:17 PM
In T290000#7321307, @dom_walden wrote:

This does not affect the way results appear when they are written to the database or dump file.

Here is an example of how it looks when you extract the results from the dump file and pretty print them: https://www.mediawiki.org/wiki/Anti-Harassment_Tools/SecurePoll_Improvements/Test_Results/5_2_5000_956342267/dump

@dom_walden does this happen when the result is written to the database and the Tally page reads it from the database? Ref T289186

gerritbot added a comment.Aug 31 2021, 9:55 PM

Change 715799 had a related patch set uploaded (by TsepoThoabala; author: TsepoThoabala):

[mediawiki/extensions/SecurePoll@master] Tally page display issues when numbers are above 1000

https://gerrit.wikimedia.org/r/715799

gerritbot added a project: Patch-For-Review.Aug 31 2021, 9:55 PM
• TThoabala moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Aug 31 2021, 9:56 PM
dom_walden added a comment.Sep 1 2021, 8:15 AM
In T290000#7322418, @Niharika wrote:
In T290000#7321307, @dom_walden wrote:

This does not affect the way results appear when they are written to the database or dump file.

Here is an example of how it looks when you extract the results from the dump file and pretty print them: https://www.mediawiki.org/wiki/Anti-Harassment_Tools/SecurePoll_Improvements/Test_Results/5_2_5000_956342267/dump

@dom_walden does this happen when the result is written to the database and the Tally page reads it from the database? Ref T289186

Yes, the bug still happens in this case.

gerritbot added a comment.Sep 2 2021, 9:53 PM

Change 715799 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Fix display issues when numbers are above 1000 or small

https://gerrit.wikimedia.org/r/715799

Maintenance_bot removed a project: Patch-For-Review.Sep 2 2021, 10:10 PM
• TThoabala moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Sep 3 2021, 6:44 AM
dom_walden moved this task from QA/Testing 🐞 to Done: Q1 (2021-22) on the Anti-Harassment (The Letter Song) board.EditedSep 6 2021, 1:20 PM

I rechecked all the examples in the description, all the stackoverflow moderator elections on beta and the Irish general election locally, concentrating on the numbers over 1000.

I saw no display issues and the calculations that I checked appeared correct (when I did the arithmetic in my head).

I also saw no errors in the beta logs.

The numbers I tested with were between 1000 and 10000, including votes per candidate, votes transferred and quota. Maybe we will get numbers bigger than that one day, but probably not for some time.

Test environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 3.0.0 (cdd701e) 06:21, 6 September 2021.

gerritbot added a comment.Sep 6 2021, 11:41 PM

Change 719166 had a related patch set uploaded (by Tim Starling; author: TsepoThoabala):

[mediawiki/extensions/SecurePoll@wmf/1.37.0-wmf.21] Fix display issues when numbers are above 1000 or small

https://gerrit.wikimedia.org/r/719166

gerritbot added a project: Patch-For-Review.Sep 6 2021, 11:41 PM
gerritbot added a comment.Sep 6 2021, 11:46 PM

Change 719166 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@wmf/1.37.0-wmf.21] Fix display issues when numbers are above 1000 or small

https://gerrit.wikimedia.org/r/719166

Stashbot added a comment.Sep 6 2021, 11:52 PM

Mentioned in SAL (#wikimedia-operations) [2021-09-06T23:52:02Z] <tstarling@deploy1002> Synchronized php-1.37.0-wmf.21/extensions/SecurePoll/includes/Talliers/STVTallier.php: T290000 (duration: 00m 58s)

Maintenance_bot removed a project: Patch-For-Review.Sep 7 2021, 12:10 AM
Niharika closed this task as Resolved.Sep 14 2021, 12:26 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits