Page MenuHomePhabricator
Create Task
Maniphest T291268

mediawiki/core CI throws PHP deprecation warnings 'Premature access to service'
Closed, ResolvedPublic
Actions

Description

See https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php72-docker/53754/consoleFull.

22:28:34 PHP Deprecated:  Premature access to service container [Called from Title::secureAndSplit in /workspace/src/includes/Title.php at line 3090] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'HookContainer' [Called from MediaWiki\MediaWikiServices::getInstance in /workspace/src/includes/MediaWikiServices.php at line 268] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'ObjectFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 619] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'TitleParser' [Called from Title::secureAndSplit in /workspace/src/includes/Title.php at line 3090] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service '_MediaWikiTitleCodec' [Called from Wikimedia\Services\ServiceContainer::createService in /workspace/src/vendor/wikimedia/services/src/ServiceContainer.php at line 447] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'ContentLanguage' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 1888] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'LanguageFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 380] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'MainConfig' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 706] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'ConfigFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 828] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'BootstrapConfig' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 347] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'LocalisationCache' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 707] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'LanguageNameUtils' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 802] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'LanguageFallback' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 709] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'LanguageConverterFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 710] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'GenderCache' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 1889] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'NamespaceInfo' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 587] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'DBLoadBalancer' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 591] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'DBLoadBalancerFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 458] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'StatsdDataFactory' [Called from ObjectCache::newFromParams in /workspace/src/includes/objectcache/ObjectCache.php at line 149] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'MainWANObjectCache' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 481] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'LocalServerObjectCache' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 486] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'ConfiguredReadOnlyMode' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 495] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'CriticalSectionProvider' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 499] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service '_DefaultOptionsLookup' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 592] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'InterwikiLookup' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 1891] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'TitleFormatter' [Called from TrivialLanguageConverter::__construct in /workspace/src/includes/language/TrivialLanguageConverter.php at line 59] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'LinkCache' [Called from Title::resetArticleID in /workspace/src/includes/Title.php at line 3035] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'RestrictionStore' [Called from Title::resetArticleID in /workspace/src/includes/Title.php at line 3036] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'CommentStore' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 1351] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'PageStore' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 1353] in /workspace/src/includes/debug/MWDebug.php on line 375
22:28:34 PHP Deprecated:  Premature access to service 'PageStoreFactory' [Called from Wikimedia\Services\ServiceContainer::{closure} in /workspace/src/includes/ServiceWiring.php at line 1056] in /workspace/src/includes/debug/MWDebug.php on line 375

Details

SubjectRepoBranchLines +/-
tests: Avoid trying to access the DB in data providersmediawiki/coreREL1_37+88 -106
tests: Avoid trying to access the DB in data providersmediawiki/coremaster+88 -106
Customize query in gerrit

Event Timeline

Zabe created this task.Sep 17 2021, 1:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2021, 1:53 PM
Zabe triaged this task as High priority.Sep 17 2021, 1:53 PM
Zabe updated the task description. (Show Details)
Krinkle edited projects, added MediaWiki-libs-Services, Platform Engineering; removed MediaWiki-General.EditedSep 17 2021, 2:04 PM
Krinkle subscribed.

Seems likely a regression from recent refactoring.

• Pchelolo assigned this task to xSavitar.Sep 17 2021, 3:31 PM
• Pchelolo edited projects, added Platform Team Workboards (MW Expedition); removed Platform Engineering.
• Pchelolo subscribed.

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/719341 - can't call Title::newFromText in a data provider. The Title::newFromText cases in provideEquals has to be moved back into an integration test or replaced with Title::makeTitle

Restricted Application added a project: User-xSavitar. · View Herald TranscriptSep 17 2021, 3:31 PM
gerritbot added a comment.Sep 17 2021, 3:57 PM

Change 721861 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@master] tests: Avoid trying to access the DB in data providers

https://gerrit.wikimedia.org/r/721861

gerritbot added a project: Patch-For-Review.Sep 17 2021, 3:57 PM
xSavitar added a comment.Sep 17 2021, 3:57 PM

Oops, I must have missed that, sorry! Made a patch!

gerritbot added a comment.Sep 20 2021, 11:25 AM

Change 721861 merged by jenkins-bot:

[mediawiki/core@master] tests: Avoid trying to access the DB in data providers

https://gerrit.wikimedia.org/r/721861

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.1; 2021-09-21).Sep 20 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 20 2021, 12:10 PM
gerritbot added a comment.Sep 20 2021, 9:58 PM

Change 722446 had a related patch set uploaded (by D3r1ck01; author: Derick Alangi):

[mediawiki/core@REL1_37] tests: Avoid trying to access the DB in data providers

https://gerrit.wikimedia.org/r/722446

gerritbot added a project: Patch-For-Review.Sep 20 2021, 9:58 PM
xSavitar added a comment.Sep 20 2021, 10:00 PM

@Zabe, can you confirm this no longer spams? Is the log free from this?

Zabe added a comment.Sep 21 2021, 1:49 PM
In T291268#7367221, @xSavitar wrote:

@Zabe, can you confirm this no longer spams? Is the log free from this?

Yes, looks good, https://integration.wikimedia.org/ci/job/mediawiki-quibble-vendor-mysql-php72-docker/53973/consoleFull.

gerritbot added a comment.Sep 21 2021, 4:36 PM

Change 722446 merged by jenkins-bot:

[mediawiki/core@REL1_37] tests: Avoid trying to access the DB in data providers

https://gerrit.wikimedia.org/r/722446

ReleaseTaggerBot added a project: MW-1.37-notes.Sep 21 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 21 2021, 5:11 PM
Zabe closed this task as Resolved.Sep 26 2021, 12:02 AM
Zabe removed a project: User-Zabe.Apr 13 2022, 12:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits