Page MenuHomePhabricator
Create Task
Maniphest T291828

Remove transitionary Dispatch Config
Closed, ResolvedPublic
Actions

Description

After dispatching via jobs has been rolled out via all of the Wikimedia wikis, we can remove the transitional configuration:

  • dispatchViaJobsAllowedClients -> to be removed, it should always be enabled for all clients
  • remove config setting dispatchViaJobsEnabled -> always enabled
  • remove config setting dispatchViaJobsPruneChangesTableInJobEnabled -> always enabled

Details

SubjectRepoBranchLines +/-
Remove dispatchViaJobs-related Wikibase settingsoperations/mediawiki-configmaster+0 -4
Enable dispatching via jobs by defaultmediawiki/extensions/Wikibasewmf/1.38.0-wmf.5+3 -3
Enable dispatching via jobs by defaultmediawiki/extensions/Wikibasemaster+3 -3
Remove wmg variables for dispatch via jobsoperations/mediawiki-configmaster+0 -19
Unconditionally enable Wikibase dispatching via jobsoperations/mediawiki-configmaster+2 -8
Remove $wmgWikibaseDispatchViaJobsAllowedClientsoperations/mediawiki-configmaster+0 -11
Set dispatchViaJobsAllowedClients to null everywhereoperations/mediawiki-configmaster+2 -7
Untangle “dispatch via jobs” settings in Wikibase.phpoperations/mediawiki-configmaster+7 -8
Set wmgWikibaseDispatchViaJobsPruneChangesTableInJobEnabled for wikidatawikioperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Sep 27 2021, 12:50 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2021, 12:50 PM
Michael changed the task status from Open to Stalled.Sep 27 2021, 12:51 PM

This will be one of the last cleanup tasks

Michael added projects: Wikibase change dispatching scripts to jobs, Wikidata.Sep 27 2021, 12:51 PM
Michael mentioned this in T291830: Post Dispatch Changes Migration Checklist.Sep 27 2021, 1:14 PM
Michael added a parent task: T291830: Post Dispatch Changes Migration Checklist.Sep 27 2021, 1:38 PM
Michael moved this task from Backlog to ToDo on the Wikibase change dispatching scripts to jobs board.Oct 8 2021, 12:49 PM
Michael updated the task description. (Show Details)Oct 8 2021, 2:26 PM
Lucas_Werkmeister_WMDE changed the task status from Stalled to Open.Oct 13 2021, 2:21 PM
Lucas_Werkmeister_WMDE subscribed.

I think we can unstall this, it should happen before T292604: Clean up old change dispatching code (otherwise the default will be no dispatching…)

gerritbot added a comment.Oct 14 2021, 10:52 AM

Change 730725 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Set wmgWikibaseDispatchViaJobsPruneChangesTableInJobEnabled for wikidatawiki

https://gerrit.wikimedia.org/r/730725

gerritbot added a project: Patch-For-Review.Oct 14 2021, 10:52 AM

Change 730746 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Untangle \u201Cdispatch via jobs\u201D settings in Wikibase.php

https://gerrit.wikimedia.org/r/730746

gerritbot added a comment.Oct 14 2021, 10:52 AM

Change 730747 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Set dispatchViaJobsAllowedClients to null everywhere

https://gerrit.wikimedia.org/r/730747

gerritbot added a comment.Oct 14 2021, 10:52 AM

Change 730748 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Remove $wmgWikibaseDispatchViaJobsAllowedClients

https://gerrit.wikimedia.org/r/730748

gerritbot added a comment.Oct 14 2021, 12:10 PM

Change 730725 merged by jenkins-bot:

[operations/mediawiki-config@master] Set wmgWikibaseDispatchViaJobsPruneChangesTableInJobEnabled for wikidatawiki

https://gerrit.wikimedia.org/r/730725

Stashbot added a comment.Oct 14 2021, 12:12 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-14T12:12:47Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:730725|Set wmgWikibaseDispatchViaJobsPruneChangesTableInJobEnabled for wikidatawiki (T291828)]] (no-op) (duration: 01m 05s)

gerritbot added a comment.Oct 14 2021, 12:16 PM

Change 730746 merged by jenkins-bot:

[operations/mediawiki-config@master] Untangle \u201Cdispatch via jobs\u201D settings in Wikibase.php

https://gerrit.wikimedia.org/r/730746

Stashbot added a comment.Oct 14 2021, 12:19 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-14T12:19:14Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:730746|Untangle “dispatch via jobs” settings in Wikibase.php (T291828)]] (no-op) (duration: 01m 04s)

Lucas_Werkmeister_WMDE claimed this task.Oct 15 2021, 10:59 AM
gerritbot added a comment.Oct 15 2021, 11:00 AM

Change 731014 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Unconditionally enable Wikibase dispatching via jobs

https://gerrit.wikimedia.org/r/731014

gerritbot added a comment.Oct 15 2021, 11:00 AM

Change 731015 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Remove wmg variables for dispatch via jobs

https://gerrit.wikimedia.org/r/731015

Lucas_Werkmeister_WMDE moved this task from ToDo to Needs Review on the Wikibase change dispatching scripts to jobs board.Oct 15 2021, 11:00 AM
gerritbot added a comment.Oct 15 2021, 11:02 AM

Change 731016 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Enable dispatching via jobs by default

https://gerrit.wikimedia.org/r/731016

gerritbot added a comment.Oct 18 2021, 11:45 AM

Change 730747 merged by jenkins-bot:

[operations/mediawiki-config@master] Set dispatchViaJobsAllowedClients to null everywhere

https://gerrit.wikimedia.org/r/730747

Stashbot added a comment.Oct 18 2021, 11:48 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T11:48:33Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:730747|Set dispatchViaJobsAllowedClients to null everywhere (T291828)]] (duration: 00m 56s)

gerritbot added a comment.Oct 18 2021, 11:52 AM

Change 730748 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove $wmgWikibaseDispatchViaJobsAllowedClients

https://gerrit.wikimedia.org/r/730748

Stashbot added a comment.Oct 18 2021, 11:54 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T11:54:16Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:730748|Remove $wmgWikibaseDispatchViaJobsAllowedClients (T291828)]] (1/2) (duration: 00m 56s)

Stashbot added a comment.Oct 18 2021, 11:55 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T11:55:26Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:730748|Remove $wmgWikibaseDispatchViaJobsAllowedClients (T291828)]] (2/2) (duration: 00m 56s)

gerritbot added a comment.Oct 18 2021, 1:30 PM

Change 731014 merged by jenkins-bot:

[operations/mediawiki-config@master] Unconditionally enable Wikibase dispatching via jobs

https://gerrit.wikimedia.org/r/731014

Stashbot added a comment.Oct 18 2021, 1:35 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T13:35:25Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:731014|Unconditionally enable Wikibase dispatching via jobs (T291828)]] (duration: 00m 56s)

gerritbot added a comment.Oct 18 2021, 1:44 PM

Change 731015 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove wmg variables for dispatch via jobs

https://gerrit.wikimedia.org/r/731015

Stashbot added a comment.Oct 18 2021, 1:47 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T13:47:16Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Config: [[gerrit:731015|Remove wmg variables for dispatch via jobs (T291828)]] (1/2) (duration: 00m 56s)

Stashbot added a comment.Oct 18 2021, 1:48 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-18T13:48:22Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/InitialiseSettings-labs.php: Config: [[gerrit:731015|Remove wmg variables for dispatch via jobs (T291828)]] (2/2) (duration: 00m 56s)

Lucas_Werkmeister_WMDE moved this task from Needs Review to Doing on the Wikibase change dispatching scripts to jobs board.Oct 18 2021, 1:49 PM
gerritbot added a comment.Oct 20 2021, 9:46 AM

Change 731016 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Enable dispatching via jobs by default

https://gerrit.wikimedia.org/r/731016

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 20 2021, 10:00 AM
gerritbot added a comment.Oct 20 2021, 4:05 PM

Change 732372 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[operations/mediawiki-config@master] Remove dispatchViaJobs-related Wikibase settings

https://gerrit.wikimedia.org/r/732372

gerritbot added a comment.Oct 21 2021, 11:35 AM

Change 732666 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Enable dispatching via jobs by default

https://gerrit.wikimedia.org/r/732666

gerritbot added a comment.Oct 21 2021, 2:34 PM

Change 732666 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@wmf/1.38.0-wmf.5] Enable dispatching via jobs by default

https://gerrit.wikimedia.org/r/732666

Stashbot added a comment.Oct 21 2021, 2:42 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-21T14:42:50Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.5/extensions/Wikibase/repo/config/Wikibase.default.php: Backport: [[gerrit:732666|Enable dispatching via jobs by default (T291828)]] (duration: 00m 55s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.5; 2021-10-19); removed MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 21 2021, 3:00 PM
gerritbot added a comment.Oct 25 2021, 11:03 AM

Change 732372 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove dispatchViaJobs-related Wikibase settings

https://gerrit.wikimedia.org/r/732372

Stashbot added a comment.Oct 25 2021, 11:05 AM

Mentioned in SAL (#wikimedia-operations) [2021-10-25T11:05:57Z] <lucaswerkmeister-wmde@deploy1002> Synchronized wmf-config/Wikibase.php: Config: [[gerrit:732372|Remove dispatchViaJobs-related Wikibase settings (T291828)]] (duration: 00m 56s)

Lucas_Werkmeister_WMDE closed this task as Resolved.Oct 25 2021, 11:26 AM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Doing to Done on the Wikibase change dispatching scripts to jobs board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits