Page MenuHomePhabricator
Create Task
Maniphest T292089

Remove tests about testing wellformedness of instances of user-defined types.
Closed, ResolvedPublic
Actions

Description

During the triage meeting of Sept 29th we decided that instances of user-defined types are difficult to validate using the same method as built-in ones. We determine to allow storage of not-wellformed user-defined types

Details

SubjectRepoBranchLines +/-
Remove unnecessary tests on GenericZObjectsTest and fix OptionalKeysTestmediawiki/extensions/WikiLambdamaster+2 -49
Customize query in gerrit

Event Timeline

gengh created this task.Sep 29 2021, 4:38 PM
DVrandecic moved this task from To triage to Phase η – Generic types on the Abstract Wikipedia team board.Oct 6 2021, 4:18 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase η – Generic types); removed Abstract Wikipedia team.
DVrandecic triaged this task as High priority.Oct 6 2021, 4:52 PM
gerritbot added a comment.Oct 21 2021, 3:11 PM

Change 732718 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Remove unnecessary tests on GenericZObjectsTest and fix OptionalKeysTest

https://gerrit.wikimedia.org/r/732718

gerritbot added a project: Patch-For-Review.Oct 21 2021, 3:11 PM
gerritbot added a comment.Oct 21 2021, 4:00 PM

Change 732718 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Remove unnecessary tests on GenericZObjectsTest and fix OptionalKeysTest

https://gerrit.wikimedia.org/r/732718

Maintenance_bot removed a project: Patch-For-Review.Oct 21 2021, 4:11 PM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.6; 2021-10-26).Oct 21 2021, 5:00 PM
Jdforrester-WMF moved this task from Incoming to QA / Ready to close on the Abstract Wikipedia team (Phase η – Generic types) board.Oct 25 2021, 5:36 PM
DVrandecic closed this task as Resolved.Oct 27 2021, 4:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits