Page MenuHomePhabricator

TimelineException: timeline-invalidmap
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
normalized_message
[{reqId}] {exception_url}   TimelineException: timeline-invalidmap
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.2/extensions/timeline/includes/Timeline.php(436)
#0 /srv/mediawiki/php-1.38.0-wmf.2/extensions/timeline/includes/Timeline.php(94): Timeline::fixMap(string)
#1 /srv/mediawiki/php-1.38.0-wmf.2/includes/parser/Parser.php(3948): Timeline::onTagHook(string, array, Parser, PPFrame_Hash)
#2 /srv/mediawiki/php-1.38.0-wmf.2/includes/parser/PPFrame_Hash.php(350): Parser->extensionSubstitution(array, PPFrame_Hash)
#3 /srv/mediawiki/php-1.38.0-wmf.2/includes/parser/Parser.php(2905): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#4 /srv/mediawiki/php-1.38.0-wmf.2/includes/parser/Parser.php(1573): Parser->replaceVariables(string)
#5 /srv/mediawiki/php-1.38.0-wmf.2/includes/parser/Parser.php(850): Parser->internalParse(string, boolean, boolean)
#6 /srv/mediawiki/php-1.38.0-wmf.2/includes/parser/Parser.php(899): Parser->recursiveTagParse(string)
#7 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/extension/src/Config/DataAccess.php(305): Parser->parseExtensionTagAsTopLevelDoc(string)
#8 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(175): MWParsoid\Config\DataAccess->parseWikitext(MWParsoid\Config\PageConfig, string)
#9 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/TT/ExtensionHandler.php(318): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onExtension(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#10 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/TT/TokenHandler.php(154): Wikimedia\Parsoid\Wt2Html\TT\ExtensionHandler->onTag(Wikimedia\Parsoid\Tokens\SelfclosingTagTk)
#11 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(108): Wikimedia\Parsoid\Wt2Html\TT\TokenHandler->process(array)
#12 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(149): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunk(array)
#13 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/TokenTransformManager.php(147): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#14 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/HTML5TreeBuilder.php(402): Wikimedia\Parsoid\Wt2Html\TokenTransformManager->processChunkily(string, array)
#15 [internal function]: Wikimedia\Parsoid\Wt2Html\HTML5TreeBuilder->processChunkily(string, array)
#16 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(1000): Generator->current()
#17 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(178): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#18 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(307): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#19 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(106): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#20 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Parsoid.php(166): Wikimedia\Parsoid\Core\WikitextContentModelHandler->toDOM(Wikimedia\Parsoid\Config\Env)
#21 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/src/Parsoid.php(198): Wikimedia\Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#22 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(588): Wikimedia\Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array, NULL)
#23 /srv/mediawiki/php-1.38.0-wmf.2/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(88): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(MWParsoid\Config\PageConfig, array)
#24 /srv/mediawiki/php-1.38.0-wmf.2/includes/Rest/Router.php(403): MWParsoid\Rest\Handler\PageHandler->execute()
#25 /srv/mediawiki/php-1.38.0-wmf.2/includes/Rest/Router.php(330): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#26 /srv/mediawiki/php-1.38.0-wmf.2/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#27 /srv/mediawiki/php-1.38.0-wmf.2/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#28 /srv/mediawiki/php-1.38.0-wmf.2/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#29 /srv/mediawiki/w/rest.php(3): require(string)
#30 {main}
Impact

~50 errors on itwiki in a 30min window

Notes

Details

Request URL
https://it.wikipedia.org/w/rest.php/it.wikipedia.org/v3/page/pagebundle/Sonic_(serie)/123016363

Related Objects

StatusSubtypeAssignedTask
ResolvedReleasejeena
ResolvedPRODUCTION ERRORLegoktm

Event Timeline

Legoktm added a project: EasyTimeline.
Legoktm subscribed.

Two issues here, one being the actual invalid map, and secondly that the fixMap exception isn't caught and handled.

Screenshot 2021-09-29 at 14-39-21 Sonic (serie) - Wikipedia.png (1×3 px, 638 KB)

This timeline has been broken for a while, it's just the failure mode shouldn't bubble up and take down the whole page.

Change 724855 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/timeline@master] Catch TimelineException from fixMap()

https://gerrit.wikimedia.org/r/724855

Change 724797 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/extensions/timeline@wmf/1.38.0-wmf.2] Catch TimelineException from fixMap()

https://gerrit.wikimedia.org/r/724797

Change 724855 merged by jenkins-bot:

[mediawiki/extensions/timeline@master] Catch TimelineException from fixMap()

https://gerrit.wikimedia.org/r/724855

Change 724797 merged by jenkins-bot:

[mediawiki/extensions/timeline@wmf/1.38.0-wmf.2] Catch TimelineException from fixMap()

https://gerrit.wikimedia.org/r/724797

Mentioned in SAL (#wikimedia-operations) [2021-09-29T21:57:24Z] <legoktm@deploy1002> Synchronized php-1.38.0-wmf.2/extensions/timeline/includes/Timeline.php: Catch TimelineException from fixMap() (T292126) (duration: 01m 07s)

https://it.wikipedia.org/wiki/Sonic_(serie) now renders most of the page with an error message coming from the <timeline> block.