Page MenuHomePhabricator

Upgrade to Gerrit 3.4
Closed, ResolvedPublic

Description

We currently run Gerrit 3.3.6 which should still be supported for a year but we should plan on upgrading to 3.4.

Release notes https://www.gerritcodereview.com/3.4.html

Some notes:

  • Java 11 by default (we already run under Java 11)
  • Schema change to add search operators mergedafter and mergedbefore

Breaking change

And a few new features.

Event Timeline

This comment was removed by hashar.

Change 756111 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/puppet@production] gerrit: port our theme to JavaScript

https://gerrit.wikimedia.org/r/756111

For the conversion of our gerrit-theme from HTML to Javascript, I have filed a the subtask T299877

Change 787000 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@deploy/wmf/stable-3.4] Gerrit v3.4.3 and rebuild plugins

https://gerrit.wikimedia.org/r/787000

Mentioned in SAL (#wikimedia-releng) [2022-04-27T19:06:30Z] <hashar> Updating operations/software/gerrit branches and tags from upstream # T292759

Change 787055 had a related patch set uploaded (by Hashar; author: Hashar):

[operations/software/gerrit@wmf/stable-3.4] Merge tag 'v3.4.4' into wmf/stable-3.4

https://gerrit.wikimedia.org/r/787055

Change 787055 merged by jenkins-bot:

[operations/software/gerrit@wmf/stable-3.4] Merge tag 'v3.4.4' into wmf/stable-3.4

https://gerrit.wikimedia.org/r/787055

I have scheduled the upgrade tomorrow at 8:00 UTC (10:00 CEST) https://wikitech.wikimedia.org/wiki/Deployments#Thursday,_April_28

I have send the announcement to wikitech-l and ops-l mailing lists.

Rollback to 3.3 is described in the Gerrit 3.4 release notes:

Downgrade

Downgrade to any Gerrit v3.3.x release is possible, but requires the following manual steps:

  • Shutdown a migrated Gerrit v3.4.x server
  • Run Gerrit v3.3.x init
  • Startup Gerrit v3.3.x server

Change 787000 merged by jenkins-bot:

[operations/software/gerrit@deploy/wmf/stable-3.4] Gerrit v3.4.4 and rebuild plugins

https://gerrit.wikimedia.org/r/787000

Mentioned in SAL (#wikimedia-operations) [2022-04-28T08:04:38Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@031f315]: Gerrit to 3.4.4 on gerrit2001 # T292759

Mentioned in SAL (#wikimedia-operations) [2022-04-28T08:04:48Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@031f315]: Gerrit to 3.4.4 on gerrit2001 # T292759 (duration: 00m 11s)

There is no changes to gerrit.config after the upgrade on gerrit2001:

Info: Applying configuration version '(1f0a039f04) Giuseppe Lavagetto - varnish: remove absented resource'
Notice: /Stage[main]/Gerrit::Jetty/Systemd::Service[gerrit]/Service[gerrit]/ensure: ensure changed 'stopped' to 'running' (corrective)
Info: /Stage[main]/Gerrit::Jetty/Systemd::Service[gerrit]/Service[gerrit]: Unscheduling refresh on Service[gerrit]
Notice: Applied catalog in 28.18 seconds

Mentioned in SAL (#wikimedia-operations) [2022-04-28T08:09:59Z] <hashar@deploy1002> Started deploy [gerrit/gerrit@031f315]: Gerrit to 3.4.4 on gerrit1001 # T292759

Mentioned in SAL (#wikimedia-operations) [2022-04-28T08:10:09Z] <hashar@deploy1002> Finished deploy [gerrit/gerrit@031f315]: Gerrit to 3.4.4 on gerrit1001 # T292759 (duration: 00m 09s)

Mentioned in SAL (#wikimedia-operations) [2022-04-28T08:12:45Z] <hashar> Stopping Gerrit for version ugprade # T292759

Both Gerrit instances have been upgraded and the service seems to work properly. For any Regression we might find, we can file them against Gerrit (Gerrit 3.4)