Page MenuHomePhabricator
Create Task
Maniphest T292787

Clean Up getTypeZID and Redundant Code in createSchema
Closed, ResolvedPublic
Actions

Description

In function-orchestrator/src/utils.js, getTypeZID and createSchema have some overlapping functionality.
This functionality likewise overlaps with the TypeKeys in function-schemata/javascript/src/schema.js.
This functionality should all be collapsed into a single utility function, ideally in function-schemata.

Details

SubjectRepoBranchLines +/-
Update function-schemata sub-module to HEAD (e130e59)mediawiki/extensions/WikiLambdamaster+1 -1
utils: Remove getTypeZID and instead use ZObjectKeyFactorymediawiki/services/function-orchestratormaster+42 -83
Update function-schemata sub-module to HEAD (e130e59)mediawiki/services/function-orchestratormaster+5 -5
Update function-schemata sub-module to HEAD (e130e59)mediawiki/services/function-orchestratormaster+9 K -779
Update function-schemata sub-module to HEAD (e130e59)mediawiki/services/function-evaluatormaster+1 -1
Create keys for arbitrary ZObjects in addition to types.mediawiki/services/function-schematamaster+169 -80
Customize query in gerrit

Related Objects

Event Timeline

cmassaro created this task.Oct 7 2021, 8:28 PM
DVrandecic moved this task from To triage to To triage: Un-phased work on the Abstract Wikipedia team board.Oct 13 2021, 4:15 PM
cmassaro added a comment.Nov 3 2021, 5:58 PM

This logic should all be collapsed with keyForGeneric, too. Type ZID inference must take into account Z9s, Z7s, and Z4s.

cmassaro added a project: good first task.Dec 1 2021, 12:17 AM
cmassaro updated the task description. (Show Details)
cmassaro claimed this task.Dec 1 2021, 4:05 PM
DVrandecic moved this task from To triage: Un-phased work to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:39 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
gerritbot added a comment.Dec 1 2021, 8:35 PM

Change 742999 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Create keys for arbitrary ZObjects in addition to types.

https://gerrit.wikimedia.org/r/742999

gerritbot added a project: Patch-For-Review.Dec 1 2021, 8:35 PM
gerritbot added a comment.Dec 6 2021, 4:01 PM

Change 744036 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Clean up createSchema, getTypeZID, etc.

https://gerrit.wikimedia.org/r/744036

gerritbot added a comment.Dec 6 2021, 6:31 PM

Change 742999 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Create keys for arbitrary ZObjects in addition to types.

https://gerrit.wikimedia.org/r/742999

cmassaro mentioned this in rMSFS756d40f472b1: Create keys for arbitrary ZObjects in addition to types..Dec 6 2021, 6:31 PM
gerritbot added a comment.Dec 6 2021, 7:49 PM

Change 744082 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (faa93ac)

https://gerrit.wikimedia.org/r/744082

gerritbot added a comment.Dec 6 2021, 7:49 PM

Change 744083 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (faa93ac)

https://gerrit.wikimedia.org/r/744083

gerritbot added a comment.Dec 6 2021, 7:49 PM

Change 744084 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (faa93ac)

https://gerrit.wikimedia.org/r/744084

gerritbot added a comment.Dec 9 2021, 4:51 PM

Change 745566 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/745566

gerritbot added a comment.Dec 9 2021, 4:57 PM

Change 744084 merged by jenkins-bot:

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744084

Jdforrester-WMF mentioned this in rMSFE79aa1b46f059: Update function-schemata sub-module to HEAD (e130e59).Dec 9 2021, 4:59 PM
gerritbot added a comment.Dec 9 2021, 6:42 PM

Change 745566 abandoned by Jforrester:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

Reason:

https://gerrit.wikimedia.org/r/745566

gerritbot added a comment.Dec 9 2021, 6:43 PM

Change 744082 merged by Cory Massaro:

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744082

cmassaro mentioned this in rMSFOe08fe9d60da7: Update function-schemata sub-module to HEAD (e130e59).Dec 9 2021, 6:44 PM
gerritbot added a comment.Dec 9 2021, 6:52 PM

Change 744036 merged by jenkins-bot:

[mediawiki/services/function-orchestrator@master] utils: Remove getTypeZID and instead use ZObjectKeyFactory

https://gerrit.wikimedia.org/r/744036

Jdforrester-WMF mentioned this in rMSFO4022ca39d117: utils: Remove getTypeZID and instead use ZObjectKeyFactory.Dec 9 2021, 6:53 PM
gerritbot added a comment.Dec 9 2021, 7:08 PM

Change 744083 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (e130e59)

https://gerrit.wikimedia.org/r/744083

Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed good first task.Jan 18 2022, 7:54 PM
cmassaro added a comment.EditedFeb 2 2022, 7:32 PM

This was fixed a while ago and can be closed.

DVrandecic closed this task as Resolved.Feb 8 2022, 5:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits