Page MenuHomePhabricator

Regression: Hidden file revisions are no longer styled
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:
The text is not styled
What should have happened instead?:
The revision should have been styled, i.e., had been crossed through and greyed out.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:
Before regression on 1.36.2

Hidden file revisions before regression (30×743 px, 4 KB)

After regression
Hidden file revisions after regression (31×961 px, 3 KB)

Event Timeline

Please provide an example link.

The styling is done with class=history-deleted or mw-history-suppressed which are still there

The CSS is also there https://gerrit.wikimedia.org/g/mediawiki/core/+/3893aab376d34cbd674246d31283b060a0be63bf/resources/src/mediawiki.interface.helpers.styles.less#129

It works when the module gets loaded (to see the effect: put mw.loader.load(['mediawiki.interface.helpers.styles']); in the console)

The style seems to be duplicated from resources/src/mediawiki.skinning/legacy.less to core in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/681138
Works with Timeless - https://en.wikipedia.org/wiki/File:Star_Wars_Phantom_Menace_poster.jpg?useskin=timeless#filehistory - which still loads the module

The style were than no longer loaded in the skins with T287410 - that makes the missing module load in core visible, that means this is similar to T288907

Change 739011 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Add stylesheet for history-deleted for file history on file pages

https://gerrit.wikimedia.org/r/739011

Change 739011 merged by jenkins-bot:

[mediawiki/core@master] Add stylesheet for history-deleted for file history on file pages

https://gerrit.wikimedia.org/r/739011

Umherirrender claimed this task.
Umherirrender triaged this task as Low priority.
Umherirrender removed a project: Patch-For-Review.