Page MenuHomePhabricator

Built-in functions don't have an evaluate form on Denny's wiki
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Freshly installed wiki
  • Go to Z801

What happens?:

Screen Shot 2021-10-12 at 5.51.13 PM.png (1×2 px, 155 KB)

I don't get a form where I can enter the input for the function

What should have happened instead?:
I should get the form

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

Jdforrester-WMF renamed this task from Built-in functions don't have an evaluate form to Built-in functions don't have an evaluate form on Denny's wiki.Oct 13 2021, 4:29 PM
SimoneThisDot subscribed.

I have managed to replicate this with a fresh install of the application.

After further investigation I have noticed that the issue is due to the function Object being structured differently and the Frontend not able to fetch the ObjectID. I am not going to fix this until I have further confirmation of the change to understand if I need to make a wider change to this.

So currently we definition of Root Zobject for us is:

`root ZObjectId, equivalend to the Z_REFERENCE_ID of Z_PERSISTENTOBJECT_ID`

But on fresh installation the above has changed to be a Z_STRING instead.

image.png (356×1 px, 37 KB)

@DVrandecic my question is the following:
Have we actually changed the structure to use a string instead than a reference, was it a mistake that should actually be reverted in the backend or should I update the frontend to expect either a string or reference? Or if you think no change happened in the Backend, I will investigate the FE code to make sure that nothing further has changed

As discussed today: Yes, we did change the structure to use a string instead of a reference. That was not a mistake, but intentional. So the front end needs to be updated.

Thanks!

Change 732263 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/WikiLambda@master] Convert Persisten object to be a string instead than reference

https://gerrit.wikimedia.org/r/732263

Change 732263 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update Persistent object to use a string not a reference for Z2K1

https://gerrit.wikimedia.org/r/732263