ApiGetBookCreatorBoxContent.php on line 39
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	dancy
	Oct 13 2021, 7:45 PM

Description

Error

mwversion: 1.38.0-wmf.4
reqId: 7a3868b0-4dda-4374-9848-c88a23937c04
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   TypeError: Argument 1 passed to CollectionHooks::getBookCreatorBoxContent() must be an instance of Title, null given, called in /srv/mediawiki/php-1.38.0-wmf.4/extensions/Collection/includes/Api/ApiGetBookCreatorBoxContent.php

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.4/extensions/Collection/includes/CollectionHooks.php(264)
#0 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Collection/includes/Api/ApiGetBookCreatorBoxContent.php(39): CollectionHooks::getBookCreatorBoxContent(NULL, string, integer)
#1 /srv/mediawiki/php-1.38.0-wmf.4/extensions/Collection/includes/Api/ApiCollection.php(71): MediaWiki\Extensions\Collection\Api\ApiGetBookCreatorBoxContent->execute()
#2 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(1878): MediaWiki\Extensions\Collection\Api\ApiCollection->execute()
#3 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(857): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.38.0-wmf.4/includes/api/ApiMain.php(828): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.38.0-wmf.4/api.php(90): ApiMain->execute()
#6 /srv/mediawiki/php-1.38.0-wmf.4/api.php(45): wfApiMain()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

Notes

Started seeing these after rolling group1 to wmf.4.

Details

Request URL: https://mh.wikipedia.org/w/api.php?action=collection&hint=*&oldid=*&pagename=*&submodule=*

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fall back to main page if given title is invalid	mediawiki/extensions/Collection	wmf/1.38.0-wmf.4	+1 -0
	Fall back to main page if given title is invalid	mediawiki/extensions/Collection	master	+1 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	dancy	T281168 1.38.0-wmf.4 deployment blockers
		Resolved	PRODUCTION ERROR	Zabe	T293299 TypeError: Argument 1 passed to CollectionHooks::getBookCreatorBoxContent() must be an instance of Title, null given, called in /srv/mediawiki/php-1.38.0-wmf.4/extensions/Collection/includes/Api/ApiGetBookCreatorBoxContent.php on line 39

Event Timeline

dancy created this task.Oct 13 2021, 7:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 13 2021, 7:45 PM

dancy added a parent task: T281168: 1.38.0-wmf.4 deployment blockers.Oct 13 2021, 7:56 PM

Zabe subscribed.Oct 13 2021, 7:56 PM

Change 730628 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Collection@master] Fall back to main page if given title is invalid

https://gerrit.wikimedia.org/r/730628

gerritbot added a project: Patch-For-Review.Oct 13 2021, 7:56 PM

Caused by https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Collection/+/725096, T291399: Turn usage of AJAX interface to API Modules (2).

Zabe claimed this task.Oct 13 2021, 7:58 PM

Change 730628 merged by jenkins-bot:

[mediawiki/extensions/Collection@master] Fall back to main page if given title is invalid

https://gerrit.wikimedia.org/r/730628

Change 730574 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.4] Fall back to main page if given title is invalid

https://gerrit.wikimedia.org/r/730574

Change 730574 merged by jenkins-bot:

[mediawiki/extensions/Collection@wmf/1.38.0-wmf.4] Fall back to main page if given title is invalid

https://gerrit.wikimedia.org/r/730574

brennen subscribed.Oct 13 2021, 8:48 PM

Mentioned in SAL (#wikimedia-operations) [2021-10-13T20:48:59Z] <brennen@deploy1002> Synchronized php-1.38.0-wmf.4/extensions/Collection/includes/Api/ApiGetBookCreatorBoxContent.php: Backport: [[gerrit:730574|Fall back to main page if given title is invalid (T293299)]] (duration: 01m 04s)