Page MenuHomePhabricator
Create Task
Maniphest T294185

Inject services when creating LanguageConverter instance in LanguageConverterFactory
Open, Needs TriagePublic
Actions

Description

The abstract class LanguageConverter is extended by many converters in mediawiki/core and is using currently the following services, which needs injection to avoid global state.

  • ContentLanguage
  • LanguageConverterFactory
  • LanguageFactory
  • LanguageNameUtils
  • LinkBatchFactory
  • LocalServerObjectCache
  • MessageCache
  • RevisionLookup
  • UserOptionsLookup

The services UserOptionsLookup (via UserOptionsManager), MessageCache and LanguageFactory (which is used by ContentLanguage, which is used by MessageCache and LinkBatchFactory) itself using the LanguageConverterFactory as a service, which gives a circular dependency.
If T243310 gets fixed than RevisionLookup is also using the service (via RevisionStore via RevisionStoreFactory via ContentHandlerFactory)

The global state about configs is handled in T244219

Related Objects

Event Timeline

Umherirrender created this task.Oct 23 2021, 10:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 23 2021, 10:00 PM
Umherirrender added a comment.Oct 24 2021, 10:50 AM

This is only a problem when the services are injected by setters like done for SpecialPage class. When passing the services through all sub classes, than it could work.
Non of the sub classes provide own constructor at the moment (only CrhConverter has construct to fill cache, but that feals wrong, because that makes the instance of the object expensive when the data possible not needed).

DannyS712 subscribed.Oct 25 2021, 4:17 AM
Umherirrender unsubscribed.Jan 2 2022, 9:00 PM
Winston_Sung moved this task from Backlog to Core on the MediaWiki-Language-converter board.Mar 18 2023, 3:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits