Missing icons from Contributions dropdown
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bebiezaza
	Oct 29 2021, 5:27 PM

Description

It seems like the contributions dropdown icons are missing. I checked both enwiki and thwiki and both of them are missing the same icons. I don't know if any other wikis have the same problem due to me not knowing any other wikis that have this feature enabled.

Details

	Subject	Repo	Branch	Lines +/-
	Restore icons to callout	mediawiki/extensions/ContentTranslation	master	+10 -0

Customize query in gerrit

Related Objects

Mentioned Here: rECTXd6dc596580f7: Use addPortletLink for injecting links

Event Timeline

Bebiezaza created this task.Oct 29 2021, 5:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 29 2021, 5:27 PM

Asartea subscribed.Oct 29 2021, 5:35 PM

Git bisect blames rECTXd6dc596580f7: Use addPortletLink for injecting links, cc @Jdlrobson

Change 736031 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/ContentTranslation@master] Restore icons to callout

https://gerrit.wikimedia.org/r/736031

gerritbot added a project: Patch-For-Review.Nov 1 2021, 6:54 PM

Thanks for the ping.

The above fix will address the situation, provided the language team is happy to own the technical debt associated and handle any future regressions relating to updates in Vector.

Legacy Vector doesn't officially support icons in menus (or callouts) which means this may break in the future, but perhaps given eventually this experience will be restricted to a smaller audience when Desktop Improvements (Vector 2022) is complete, that will only be a temporary need.

Change 736031 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Restore icons to callout

https://gerrit.wikimedia.org/r/736031

Maintenance_bot removed a project: Patch-For-Review.Nov 2 2021, 5:10 AM

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.9; 2021-11-16).Nov 2 2021, 6:00 AM

• Nikerabbit triaged this task as Medium priority.Nov 8 2021, 11:11 AM

• Nikerabbit added a project: Language-Team (Language-2021-October-December).

• Nikerabbit moved this task from Quarter Backlog to Needs QA on the Language-Team (Language-2021-October-December) board.

• Nikerabbit moved this task from Needs Triage to Bugs on the ContentTranslation board.

• Jpita moved this task from Needs QA to Recheck after deployment on the Language-Team (Language-2021-October-December) board.Nov 11 2021, 12:49 AM