Page MenuHomePhabricator
Create Task
Maniphest T294702

Deprecate and remove `global $mediaWiki`
Closed, ResolvedPublic
Actions

Description

Usages can be replaced with service calls.

  • Remove usages. These seem to be the only usages:
    • extension-BlueSpiceFlaggedRevsConnector
    • extension-FlaggedRevs
    • extension-PageDisqus
    • skin-Poncho
  • PHPCodeSniffer should complain if the global is reintroduced.
  • Finally, the global declaration in mediawiki-core index.php should be removed.

Details

SubjectRepoBranchLines +/-
index.php: Remove global $mediaWiki variablemediawiki/coremaster+0 -3
Remove global $mediaWiki usagemediawiki/extensions/FlaggedRevsmaster+2 -15
Refactor usage of global $mediaWikimediawiki/extensions/BlueSpiceFlaggedRevsConnectorREL1_35+2 -12
Refactor usage of global $mediaWikimediawiki/extensions/BlueSpiceFlaggedRevsConnectormaster+2 -12
Refactor usage of global $mediaWikimediawiki/extensions/BlueSpiceFlaggedRevsConnectorREL1_35-4.0.x+2 -12
Disallow global $mediaWikimediawiki/tools/codesniffermaster+0 -3
Refactor usage of global $mediaWikimediawiki/extensions/PageDisqusmaster+6 -6
Refactor usage of global $mediaWikimediawiki/skins/Ponchomaster+1 -2
Customize query in gerrit

Related Objects

Event Timeline

awight created this task.Oct 31 2021, 8:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 31 2021, 8:11 AM
gerritbot added a comment.Oct 31 2021, 8:27 AM

Change 735729 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/FlaggedRevs@master] Remove global $mediaWiki usage

https://gerrit.wikimedia.org/r/735729

gerritbot added a project: Patch-For-Review.Oct 31 2021, 8:27 AM
awight updated the task description. (Show Details)Oct 31 2021, 8:37 AM
gerritbot added a comment.Oct 31 2021, 8:41 AM

Change 735731 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/735731

gerritbot added a comment.Oct 31 2021, 8:46 AM

Change 735732 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/PageDisqus@master] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/735732

gerritbot added a comment.Oct 31 2021, 8:50 AM

Change 735733 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/skins/Poncho@master] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/735733

awight updated the task description. (Show Details)Oct 31 2021, 8:53 AM
gerritbot added a comment.Oct 31 2021, 8:57 AM

Change 735734 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/tools/codesniffer@master] Disallow global $mediaWiki

https://gerrit.wikimedia.org/r/735734

awight updated the task description. (Show Details)Oct 31 2021, 8:59 AM
gerritbot added a comment.Oct 31 2021, 9:02 AM

Change 735735 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/core@master] [DNM] Remove declaration of global $mediaWiki

https://gerrit.wikimedia.org/r/735735

Aklapper added projects: FlaggedRevs, MediaWiki-extensions-Other, BlueSpice, Poncho, MediaWiki-General.Oct 31 2021, 9:13 AM
gerritbot added a comment.Oct 31 2021, 1:05 PM

Change 735733 merged by jenkins-bot:

[mediawiki/skins/Poncho@master] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/735733

awight mentioned this in rMSPO62620e3ee1c5: Refactor usage of global $mediaWiki.Oct 31 2021, 1:05 PM
gerritbot added a comment.Oct 31 2021, 1:37 PM

Change 735732 merged by jenkins-bot:

[mediawiki/extensions/PageDisqus@master] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/735732

Sophivorus mentioned this in rEPDQ74e72efde9bf: Refactor usage of global $mediaWiki.Oct 31 2021, 1:55 PM
gerritbot added a comment.Nov 1 2021, 10:33 AM

Change 735734 abandoned by Awight:

[mediawiki/tools/codesniffer@master] Disallow global $mediaWiki

Reason:

Thanks, yes this was a mistake and seems unrelated. The rule for globals is already just "$wg"-, and usages of $mediaWiki should have required a special exemption already (though they did not set off phpcs alerts in some repos, for unknown reasons).

https://gerrit.wikimedia.org/r/735734

gerritbot added a comment.Nov 2 2021, 7:43 AM

Change 736049 had a related patch set uploaded (by Pwirth; author: Awight):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/736049

gerritbot added a comment.Nov 2 2021, 7:43 AM

Change 736050 had a related patch set uploaded (by Pwirth; author: Awight):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35-4.0.x] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/736050

gerritbot added a comment.Nov 2 2021, 7:55 AM

Change 736050 merged by Pwirth:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35-4.0.x] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/736050

gerritbot added a comment.Nov 2 2021, 7:55 AM

Change 735731 merged by Pwirth:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@master] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/735731

gerritbot added a comment.Nov 2 2021, 7:58 AM

Change 736049 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Refactor usage of global $mediaWiki

https://gerrit.wikimedia.org/r/736049

gerritbot added a comment.Dec 17 2021, 4:40 AM

Change 735729 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Remove global $mediaWiki usage

https://gerrit.wikimedia.org/r/735729

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 17 2021, 5:00 AM
Krinkle edited projects, added Technical-Debt (Deprecation process); removed Technical-Debt.Apr 3 2022, 9:27 PM
Krinkle moved this task from Untriaged to 2022 | MW 1.38 / 1.39 on the Technical-Debt (Deprecation process) board.
gerritbot added a comment.Apr 3 2022, 9:47 PM

Change 735735 merged by jenkins-bot:

[mediawiki/core@master] index.php: Remove global $mediaWiki variable

https://gerrit.wikimedia.org/r/735735

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.6; 2022-04-04).Apr 3 2022, 10:00 PM
Jdforrester-WMF closed this task as Resolved.Apr 4 2022, 8:55 AM
Jdforrester-WMF updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits