Linter fails to detect missing table end
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jonesey95
	Nov 5 2021, 8:11 PM

Description

List of steps to reproduce (step by step, including full links if applicable):

Create a simple table with no table-ending wikicode

See https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox2&oldid=1053750496

What happens?:
Linter does not report a missing table end.

What should have happened instead?:
Linter should report a missing table end.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

Subject	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.18.0-a26	mediawiki/vendor	master	+542 -1 K
Don't lint missing wikitext table ends when followed by deletable-table-tag	mediawiki/services/parsoid	master	+28 -29
Lint missing wikitext syntax table ends	mediawiki/services/parsoid	master	+36 -22

Customize query in gerrit

Related Objects

Mentioned In: T348296: Linter detection of missing table end has a slight problem with noinclude tags

Event Timeline

Jonesey95 created this task.Nov 5 2021, 8:11 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 5 2021, 8:11 PM

This is wikitext table syntax and Parsoid seems to ignore if it isn't a literal html tag,
https://github.com/wikimedia/parsoid/blob/master/src/Wt2Html/PP/Processors/Linter.php#L431

There's no clear explanation as to why,
https://github.com/wikimedia/parsoid/commit/7e46f1341b6b2f00bc7fc5176825abf55b2e1041
https://github.com/wikimedia/parsoid/commit/3fbaac03ea062ad3a3872f040594d14b057e1601

And there's an exception for i/b, so I suppose we need one here too.

Arlolra moved this task from Needs Triage to Linting on the Parsoid board.Nov 5 2021, 8:56 PM

Here's a demonstration that this causes actual problems:

https://en.wikipedia.org/w/index.php?title=User:Jonesey95/sandbox2&oldid=1053768927

The first section contains an unclosed table. The next two sections are contained within the unclosed table instead of being their own sections. This syntax should report one of the two table-related Linter errors.

Izno merged a task: T309435: Linter should look for unclosed table synatx.Oct 7 2022, 6:55 AM

Izno added a subscriber: ShakespeareFan00.

Arlolra triaged this task as Medium priority.Aug 15 2023, 7:34 PM

Arlolra moved this task from Backlog to Parsoid on the MediaWiki-extensions-Linter board.

Change 960128 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Lint missing wikitext syntax table ends

https://gerrit.wikimedia.org/r/960128

gerritbot added a project: Patch-For-Review.Sep 22 2023, 7:53 PM

Arlolra claimed this task.Sep 22 2023, 7:54 PM

Arlolra added a project: Content-Transform-Team-WIP.

Arlolra moved this task from Backlog to Code Review on the Content-Transform-Team-WIP board.

MSantos added a project: Essential-Work.Sep 25 2023, 3:00 PM