Page MenuHomePhabricator

Regression: Logo is missing from mobile site footer
Closed, ResolvedPublic

Description

Description

In the mobile site footer there should be the Wikipedia wordmark. Instead there is the word Wikipedia in unstyled text:

Screen Shot 2021-11-16 at 8.59.01 AM.png (752×497 px, 90 KB)

Developer notes

Broken by 894364a3eb

QA notes

For beta cluster testing purposes, we can use https://patchdemo.wmflabs.org/wikis/25cfb8cf2d to verify the change.

Confirm the logo is present in the footer.

QA Results - Beta

ACStatusDetails
1T295773#7577783

QA Results - Prod

ACStatusDetails
1T295773#7577787

Event Timeline

Jdlrobson renamed this task from Logo is missing from mobile site footer to Regression: Logo is missing from mobile site footer.Nov 29 2021, 6:57 PM
Jdlrobson updated the task description. (Show Details)

Change 742514 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Restore logo to footer

https://gerrit.wikimedia.org/r/742514

Change 742514 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Restore logo to footer

https://gerrit.wikimedia.org/r/742514

Test Result - Beta

Status: ❌ Fail
Environment: beta, patchdemo
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

❌ AC1: Verify logo is present in footer while viewing mobile.
I cannot access patchdemo, possibly waited to long to verify. In beta the wordmark is still not present

Screen Shot 2021-12-17 at 6.57.55 AM.png (278×749 px, 31 KB)

Screen Shot 2021-12-17 at 6.57.21 AM.png (901×417 px, 71 KB)

Test Result - Prod

Status: ✅ Pass
Environment: enwiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Verify logo is present in the footer while viewing mobile.

@ovasileva This didn't pass in beta, but It could be because I didn't test it earlier in patchdemo. I went ahead and tested in in Prod and it works.

Screen Shot 2021-12-17 at 7.03.30 AM.png (1×738 px, 145 KB)

Edtadros updated the task description. (Show Details)
Edtadros added a subscriber: Edtadros.