Page MenuHomePhabricator

Remove duplication of props in ApiQueryStashImageInfo by using ApiQueryImageInfo
Closed, ResolvedPublic


Describing above

More a question for Bryan than anything...

Can everything that is done on a normal image be done on a Stashed Image?

I'm wanting to remove the duplication of the properties code. See patch.

If not, what can't be done, as I want to look at doing it a bit more programatically than having all that duplication (array_diff or similar probably)

Version: unspecified
Severity: trivial




Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:25 PM
bzimport set Reference to bz27586.

Bryan.TongMinh wrote:

Stashed images don't have a comment, and possibly no user, but would need to check that. Also archivename is not applicable.

Bryan.TongMinh wrote:

Since you're working on this, I'm marking bug 27589 depending on this one, as it uses getPropertyNames() as well.