Language button visual regression
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• alexhollender_WMF
	Nov 22 2021, 6:37 PM

Description

Sometime in the past week or two the language button has changed. The icon has gotten smaller, making the gap between the icon and the button label larger. It also seems like the gap has gotten larger in addition to the extra gap from the icon size decrease.

Screen Shot 2021-11-22 at 1.37.00 PM.png (618×841 px, 91 KB)

This is also affecting the language button in the site header (Commons, Wikidata, etc.), and the language button in the new sticky header:

site header	sticky header

Details

	Subject	Repo	Branch	Lines +/-
	Restores language button icon font size	mediawiki/skins/Vector	master	+4 -2

Customize query in gerrit

Related Objects

Mentioned Here: T289815: Sticky header: Add language switching functionality to sticky header
T292452: [Minerva] Increase space between icon and text label in main menu
rSVEC54639c4af3e5: Fix icon button spacing, make it consistent with margin defined in core

Event Timeline

• alexhollender_WMF created this task.Nov 22 2021, 6:37 PM

@ovasileva @Jdlrobson @SCherukuwada @Volker_E as we've discussed in the past doing manual checks and hand-fixes for visual regressions doesn't seem like a great process

• alexhollender_WMF updated the task description. (Show Details)Nov 22 2021, 8:27 PM

Change 742788 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Restores language button icon font size

https://gerrit.wikimedia.org/r/742788

gerritbot added a project: Patch-For-Review.Nov 30 2021, 7:40 PM

In T296212#7521081, @alexhollender wrote:

@ovasileva @Jdlrobson @SCherukuwada @Volker_E as we've discussed in the past doing manual checks and hand-fixes for visual regressions doesn't seem like a great process

Agreed, @SCherukuwada is exploring with the RelEng team about having some much needed infrastructure to replace these manual checks.

As for the bug:

The margin issue looks like a regression relating to T292452 and fixed by https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/742788
The icon size looks like it was introduced by the sticky header work T289815. This has been fixed already by @bwang in 54639c4af3 but has not yet got deployed.