Page MenuHomePhabricator

Fix-It Week: Audit Existing TODOs and FIXMEs in function schemata code
Closed, ResolvedPublic

Description

  • Look at each use of FIXME, TODO, HACK, and similar inline comments in the Wikifunctions shared schemata's code.
  • Check if each one of them names a Phabricator task by ID (e.g. // (T12345) TODO: This should be factored out into an interface).
  • If such a task doesn't yet exist, create one, tagged with Abstract Wikipedia team and Technical-Debt, and other tasks as appropriate.
  • If such a task already exists, check that it's still open; if not, comment on the task asking if the comment is still valid or otherwise check if it has since been resolved or over-taken by events. If it has, make a patch removing the comment and explaining why we no longer want to do it.

Event Timeline

Aklapper added a subscriber: Aklapper.

@Jdforrester-WMF: A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the lack of a task description && the lack of information where this codebase is located (no link on https://phabricator.wikimedia.org/tag/function-schemata/ ) I'm removing the good first task tag. Please add details for a new contributor, and then add back the good first task project tag. Thanks a lot in advance!

Change 742976 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Audit TODOs in function-schemata.

https://gerrit.wikimedia.org/r/742976

Change 742976 merged by jenkins-bot:

[mediawiki/services/function-schemata@master] Audit TODOs in function-schemata.

https://gerrit.wikimedia.org/r/742976

Change 744083 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (faa93ac)

https://gerrit.wikimedia.org/r/744083

Change 744082 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-orchestrator@master] Update function-schemata sub-module to HEAD (faa93ac)

https://gerrit.wikimedia.org/r/744082

Change 744084 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/services/function-evaluator@master] Update function-schemata sub-module to HEAD (faa93ac)

https://gerrit.wikimedia.org/r/744084