Write Test Ensuring Z14s Are Resolved (but Not Compositions)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	cmassaro
	Nov 29 2021, 8:55 PM

Description

function-orchestrator code can be found at https://gerrit.wikimedia.org/g/mediawiki/services/function-orchestrator

src/execute.js (line 379 or search for this task's ID)

The implementations of a ZFunction (Z8) are stored in Z8K4. There are currently no tests asserting that all implementations therein are resolved (e.g., if they are references). Write tests where implementations show up as all of the following:

Argument References (Z18)
References (Z9)
Function Calls returning Implementations (Z7)

Details

	Subject	Repo	Branch	Lines +/-
	wikifunctions: Upgrade orchestrator from 2024-07-19-164024 to 2024-08-13-135124	operations/deployment-charts	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T310995: Composition implementations are being evaluated before being selected

Event Timeline

cmassaro created this task.Nov 29 2021, 8:55 PM

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor. Given the non-existing task description and the lack of information where to find the codebase I'm removing the good first task tag. Please add details what exactly has to happen where and how for a new contributor, and then add back the good first task project tag. Thanks a lot in advance.

cmassaro updated the task description. (Show Details)Nov 30 2021, 5:33 PM

cmassaro added a project: good first task.

DVrandecic moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:19 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed good first task.Jan 18 2022, 7:53 PM

cmassaro renamed this task from Write Test Ensuring Z14s Are Resolved to Write Test Ensuring Z14s Are Resolved (but Not Compositions).Apr 26 2022, 3:50 PM

• AAssaf subscribed.Apr 26 2022, 4:38 PM

Jdforrester-WMF moved this task from Incoming to Nice-to-haves on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:33 PM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Nov 7 2022, 5:42 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF triaged this task as High priority.Mar 24 2023, 12:42 AM

• Mcastro lowered the priority of this task from High to Medium.Jan 18 2024, 5:48 PM

• Mcastro moved this task from To triage: Nice-to-haves to Backlog on the Abstract Wikipedia team board.

cmassaro claimed this task.Jul 29 2024, 4:30 PM

This test doesn't handle the Z18 case, but our scoping rules make that kind of hard :-/

apine opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/209

Test that all Z14/Implementations are resolved before starting execution.

cmassaro moved this task from Backlog to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jul 29 2024, 9:28 PM

cmassaro edited projects, added Abstract Wikipedia team (25Q1 (Jul–Sep)); removed Abstract Wikipedia team.

cmassaro moved this task from Incoming to In Progress on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.

ecarg merged https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/209

Test that all Z14/Implementations are resolved before starting execution.

Maintenance_bot removed a project: Patch-For-Review.Jul 30 2024, 6:33 PM

Change #1064031 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-07-19-164024 to 2024-08-13-135124

https://gerrit.wikimedia.org/r/1064031

gerritbot added a project: Patch-For-Review.Aug 20 2024, 1:46 PM

Change #1064031 merged by jenkins-bot: