Page MenuHomePhabricator
Create Task
Maniphest T296724

WikiLambda: Remove validity of Z9 as value for a Z2K1
Closed, ResolvedPublic
Actions

Description

ZPersistentObject.php:132

Currently the method isValid of ZPersistentObject accepts either a ZString or a ZReference as the value for Z2K1. This is because for a while we had a bit of a mess while transitioning from Z9 to Z6, but currently all Z2K1 should already be Z6s.

  • Change isValid method so that it stops allowing Z9 as a valid value for the ID
  • Make sure that tests pass
  • Try to manually create a new ZObject from the Vue interface to make sure that we are not breaking things and the front-end is creating correct ZObjects.
  • (If not working), fix front-end to send Z6s instead of Z9s as the value for Z2K1.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Only accept Z6/String as Persistent object ID/Z2K1 (part 2)mediawiki/extensions/WikiLambdamaster+48 -37
[WIP] Drop Z9/Reference as permitted type for Z2K1 identitymediawiki/extensions/WikiLambdamaster+90 -81
Only accept Z6/String as Persistent object ID/Z2K1mediawiki/extensions/WikiLambdamaster+94 -89
Customize query in gerrit

Related Objects

Event Timeline

gengh created this task.Nov 30 2021, 12:26 PM
DVrandecic moved this task from To Triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:24 PM
DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.
Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed good first task.Jan 18 2022, 7:53 PM
gerritbot added a comment.Jul 26 2022, 7:14 PM

Change 817356 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Drop Z9/Reference as permitted type for Z2K1 identity

https://gerrit.wikimedia.org/r/817356

gerritbot added a project: Patch-For-Review.Jul 26 2022, 7:14 PM
Jdforrester-WMF moved this task from Incoming to Better before launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:32 PM
Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:00 AM
Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 14 2023, 2:03 PM
Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).
Jdforrester-WMF moved this task from To triage: Nice-to-haves to No current plans / External on the Abstract Wikipedia team board.Apr 11 2024, 4:52 PM
gengh mentioned this in T375065: [25Q2] Improve performance of the PHP layer.Sep 18 2024, 9:46 AM
gerritbot added a comment.Sep 19 2024, 9:17 AM

Change #1074114 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Only accept Z6/String as Persistent object ID/Z2K1

https://gerrit.wikimedia.org/r/1074114

gerritbot added a comment.Nov 20 2024, 5:34 PM

Change #1074114 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Only accept Z6/String as Persistent object ID/Z2K1

https://gerrit.wikimedia.org/r/1074114

Jdforrester-WMF edited projects, added Abstract Wikipedia team (25Q2 (Oct–Dec)); removed Abstract Wikipedia team.Nov 20 2024, 6:00 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.5; 2024-11-25).Nov 20 2024, 6:00 PM
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Nov 20 2024, 6:01 PM
gerritbot added a comment.Nov 21 2024, 11:39 AM

Change #1093876 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Only accept Z6/String as Persistent object ID/Z2K1 (part 2)

https://gerrit.wikimedia.org/r/1093876

gerritbot added a comment.Nov 21 2024, 3:52 PM

Change #817356 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] [WIP] Drop Z9/Reference as permitted type for Z2K1 identity

Reason:

Going with Geno's version.

https://gerrit.wikimedia.org/r/817356

gerritbot added a comment.Nov 22 2024, 10:51 PM

Change #1093876 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Only accept Z6/String as Persistent object ID/Z2K1 (part 2)

https://gerrit.wikimedia.org/r/1093876

Maintenance_bot removed a project: Patch-For-Review.Nov 22 2024, 11:30 PM
Jdforrester-WMF closed this task as Resolved.Nov 27 2024, 3:47 PM
Jdforrester-WMF assigned this task to gengh.
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits