Maniphest T296724

WikiLambda: Remove validity of Z9 as value for a Z2K1
Open, MediumPublic
Actions

Assigned To

None

Authored By

	gengh
	Nov 30 2021, 12:26 PM

Tags

Referenced Files

None

Subscribers

Description

ZPersistentObject.php:132

Currently the method isValid of ZPersistentObject accepts either a ZString or a ZReference as the value for Z2K1. This is because for a while we had a bit of a mess while transitioning from Z9 to Z6, but currently all Z2K1 should already be Z6s.

Change isValid method so that it stops allowing Z9 as a valid value for the ID
Make sure that tests pass
Try to manually create a new ZObject from the Vue interface to make sure that we are not breaking things and the front-end is creating correct ZObjects.
(If not working), fix front-end to send Z6s instead of Z9s as the value for Z2K1.

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] Drop Z9/Reference as permitted type for Z2K1 identity	mediawiki/extensions/WikiLambda	master	+90 -81

Customize query in gerrit

Event Timeline

gengh created this task.Nov 30 2021, 12:26 PM

DVrandecic moved this task from To triage to Phase κ – Clean-up on the Abstract Wikipedia team board.Dec 1 2021, 5:24 PM

DVrandecic edited projects, added Abstract Wikipedia team (Phase κ – Clean-up); removed Abstract Wikipedia team.

Jdforrester-WMF edited projects, added Abstract Wikipedia Fix-It tasks; removed good first task.Jan 18 2022, 7:53 PM

Change 817356 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] [WIP] Drop Z9/Reference as permitted type for Z2K1 identity

https://gerrit.wikimedia.org/r/817356

gerritbot added a project: Patch-For-Review.Jul 26 2022, 7:14 PM

Jdforrester-WMF moved this task from Incoming to Better before launch on the Abstract Wikipedia team (Phase κ – Clean-up) board.Oct 24 2022, 8:32 PM

Jdforrester-WMF triaged this task as Medium priority.Mar 24 2023, 1:00 AM

Jdforrester-WMF moved this task from Phase κ – Clean-up to To triage: Nice-to-haves on the Abstract Wikipedia team board.Jun 14 2023, 2:03 PM

Jdforrester-WMF edited projects, added Abstract Wikipedia team; removed Abstract Wikipedia team (Phase κ – Clean-up).

Jdforrester-WMF moved this task from To triage: Nice-to-haves to No current plans / External on the Abstract Wikipedia team board.Apr 11 2024, 4:52 PM