Page MenuHomePhabricator

License doesn't show for new page creations in mobile editor on wikinews.org
Closed, ResolvedPublicBUG REPORT

Description

Spun off from T111833.

On blank pages after clicking edit no license is shown.

Expected: The default license should be shown

Event Timeline

Change 742810 had a related patch set uploaded (by Jdlrobson; author: Bartosz Dziewoński):

[mediawiki/extensions/MobileFrontend@master] Display license in the editor even when not shown in read mode (e.g. creating new pages)

https://gerrit.wikimedia.org/r/742810

As I mentioned in T111833#7536242 and https://gerrit.wikimedia.org/r/742810 the license doesn't show is because we hide the license in the footer on pages that don't exist.

Rather than a MobileFrontend specific solution (which moving away from that was the whole point of T111833) I suggest we update the logic in https://gerrit.wikimedia.org/g/mediawiki/core/+/12dbaa863859bd3874f47c2b8107e10c42bb7697/includes/skins/Skin.php#2504 to always show the license and use CSS to hide it (a page-redlink class on the body seems like a helpful thing to have)

Alternatively, we should output this configuration in core so things other than MobileFrontend can use it.

Jdlrobson renamed this task from License doesn't show for new page creations in mobile editor to License doesn't show for new page creations in mobile editor on wikinews.org.Dec 1 2021, 6:37 PM
Jdlrobson added a subscriber: matmarex.

@matmarex this only impacts wikinews, right?

No, it also affects non-Wikimedia wikis.

No, it also affects non-Wikimedia wikis.

This is not a bug then. The whole point of the changes in MobileFrontend was to defer to editors for this change.

I've fixed Wikinews with this edit:
https://en.wikinews.org/wiki/MediaWiki:Mobile-frontend-license-links

Perhaps all that is needed here, is updating documentation/release notes around the new way to set licenses for the mobile editor.

Change 742810 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/MobileFrontend@master] Display license in the editor even when not shown in read mode (e.g. creating new pages)

Reason:

https://gerrit.wikimedia.org/r/742810

Change 743034 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/WikimediaMessages@master] Fix Wikinews license link in mobile editor

https://gerrit.wikimedia.org/r/743034

Change 743034 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Fix Wikinews license link in mobile editor

https://gerrit.wikimedia.org/r/743034

I think this is fixed. I assume QA will be done as part of the editing team's current work. Lemme know if that's not true.