Page MenuHomePhabricator

Add methods to get lemma, representation, gloss by language code
Closed, ResolvedPublic

Description

In the current WikibaseLexeme Lua, lexemes have getLemmas(), forms have getRepresentations(), and senses have getGlosses(), all of which return a plain list of value+language pairs. Methods to get the value by language code would probably be more useful: getLemma( languageCode ), getRepresentation( languageCode ), getGloss( languageCode ).

Returning the language code as a second return value (Lua!) would probably be useful for something like local lemma, language = lexeme:getLemma( complex.expression['for'].language.code ). If there is no value in the given language, return nil, of course.

Event Timeline

Change 745569 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation()

https://gerrit.wikimedia.org/r/745569

Change 745569 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation()

https://gerrit.wikimedia.org/r/745569

Change 746814 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@wmf/1.38.0-wmf.12] Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation()

https://gerrit.wikimedia.org/r/746814

Change 746814 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@wmf/1.38.0-wmf.12] Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation()

https://gerrit.wikimedia.org/r/746814

Mentioned in SAL (#wikimedia-operations) [2021-12-13T15:51:27Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/WikibaseLexeme: Backport: [[gerrit:746814|Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation() (T297024)]] (no-op because Lexeme Lua is not yet enabled in prod) (duration: 00m 57s)

Change 746907 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@wmf/1.38.0-wmf.9] Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation()

https://gerrit.wikimedia.org/r/746907

Change 746907 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@wmf/1.38.0-wmf.9] Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation()

https://gerrit.wikimedia.org/r/746907

Mentioned in SAL (#wikimedia-operations) [2021-12-13T17:47:31Z] <lucaswerkmeister-wmde@deploy1002> Synchronized php-1.38.0-wmf.9/extensions/WikibaseLexeme: Backport: [[gerrit:746907|Add lexeme:getLemma(), sense:getGloss(), form:getRepresentation() (T297024)]] (no-op because Lexeme Lua is not yet enabled in prod) (duration: 00m 57s)