Finish removal of wgTrustedXffFile
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm
	Dec 23 2021, 1:38 PM

Description

As part of T212461: Update TrustedXFF to use core's StaticArrayWriter implementation (b701bad1f83cc20d51d20885ac276d17d97a11ae, to be specific), @Krinkle removed support for wgTrustedXffFile from TrustedXFF extension. It appears our own config still sets it though (and there's still a copy of the PHP file in MW config).

Per codesearch, nothing else uses the variable, so it can be removed safely.

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove trusted-xff.php from wmf-config	operations/mediawiki-config	master	+0 -78 K
	Do not set wgTrustedXffFile	operations/mediawiki-config	master	+0 -1

Mentioned Here: rOMWC11498603a918: Remove trusted-xff.php from wmf-config
rOMWC6fa62c58c049: Do not set wgTrustedXffFile
T212461: Update TrustedXFF to use core's StaticArrayWriter implementation
rETXFb701bad1f83c: Move trusted-hosts.php artefact from wmf-config to extension repo

Urbanecm triaged this task as Low priority.

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 749734 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Do not set wgTrustedXffFile

Change 749735 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[operations/mediawiki-config@master] Remove trusted-xff.php from wmf-config

Change 749734 merged by jenkins-bot:

[operations/mediawiki-config@master] Do not set wgTrustedXffFile

Mentioned in SAL (#wikimedia-operations) [2022-01-27T19:52:49Z] <urbanecm@deploy1002> Synchronized wmf-config/CommonSettings.php: 6fa62c58c04929d7327d8f07dbd32b6139f58ccf: Do not set wgTrustedXffFile (T298243) (duration: 00m 51s)

Change 749735 merged by jenkins-bot:

[operations/mediawiki-config@master] Remove trusted-xff.php from wmf-config

Mentioned in SAL (#wikimedia-operations) [2022-01-27T19:58:39Z] <urbanecm@deploy1002> Synchronized docroot/noc/: 11498603a918863c08300b4abfc69491424ebe14: Remove trusted-xff.php from wmf-config (T298243; 1/3) (duration: 00m 50s)

Mentioned in SAL (#wikimedia-operations) [2022-01-27T19:59:56Z] <urbanecm@deploy1002> Synchronized wmf-config/: 11498603a918863c08300b4abfc69491424ebe14: Remove trusted-xff.php from wmf-config (T298243; 2/3) (duration: 00m 51s)

Mentioned in SAL (#wikimedia-operations) [2022-01-27T20:01:49Z] <urbanecm@deploy1002> Synchronized phpcs.xml: 11498603a918863c08300b4abfc69491424ebe14: Remove trusted-xff.php from wmf-config (T298243; 3/3) (duration: 00m 50s)

This is now done.